* [PATCH ARM] Fix unterminated list of options to 'set arm fallback-mode' and 'set arm force-mode'
@ 2010-10-11 16:30 Matthew Gretton-Dann
2010-10-11 16:40 ` Daniel Jacobowitz
0 siblings, 1 reply; 3+ messages in thread
From: Matthew Gretton-Dann @ 2010-10-11 16:30 UTC (permalink / raw)
To: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 510 bytes --]
All,
The attached patch adds a NULL entry at the end of the array of options
accepted by 'set arm fallback-mode' and 'set arm force-mode'. Thus
ensuring GDB doesn't go wandering off trying to print garbage from
beyond the end of an array.
Can someone please review and approve?
Thanks,
Matt
gdb/ChangeLog:
2010-10-11 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
* arm-tdep.c (arm_mode_strings): Add NULL entry at end of array.
--
Matthew Gretton-Dann
Principal Engineer - PDSW Tools
ARM Ltd
[-- Attachment #2: 1010-gdb-missing-null.patch --]
[-- Type: text/x-patch, Size: 307 bytes --]
diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index 19b9c85..5b32b8a 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -124,7 +124,8 @@ static const char *arm_mode_strings[] =
{
"auto",
"arm",
- "thumb"
+ "thumb",
+ NULL
};
static const char *arm_fallback_mode_string = "auto";
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH ARM] Fix unterminated list of options to 'set arm fallback-mode' and 'set arm force-mode'
2010-10-11 16:30 [PATCH ARM] Fix unterminated list of options to 'set arm fallback-mode' and 'set arm force-mode' Matthew Gretton-Dann
@ 2010-10-11 16:40 ` Daniel Jacobowitz
2010-10-12 8:47 ` Matthew Gretton-Dann
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2010-10-11 16:40 UTC (permalink / raw)
To: Matthew Gretton-Dann; +Cc: gdb-patches
On Mon, Oct 11, 2010 at 05:30:31PM +0100, Matthew Gretton-Dann wrote:
> All,
>
> The attached patch adds a NULL entry at the end of the array of options
> accepted by 'set arm fallback-mode' and 'set arm force-mode'. Thus
> ensuring GDB doesn't go wandering off trying to print garbage from
> beyond the end of an array.
>
> Can someone please review and approve?
Whoops, thank you.
--
Daniel Jacobowitz
CodeSourcery
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH ARM] Fix unterminated list of options to 'set arm fallback-mode' and 'set arm force-mode'
2010-10-11 16:40 ` Daniel Jacobowitz
@ 2010-10-12 8:47 ` Matthew Gretton-Dann
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Gretton-Dann @ 2010-10-12 8:47 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: gdb-patches
On Mon, 2010-10-11 at 12:40 -0400, Daniel Jacobowitz wrote:
> On Mon, Oct 11, 2010 at 05:30:31PM +0100, Matthew Gretton-Dann wrote:
> > All,
> >
> > The attached patch adds a NULL entry at the end of the array of options
> > accepted by 'set arm fallback-mode' and 'set arm force-mode'. Thus
> > ensuring GDB doesn't go wandering off trying to print garbage from
> > beyond the end of an array.
> >
> > Can someone please review and approve?
>
> Whoops, thank you.
Committed.
--
Matthew Gretton-Dann
Principal Engineer - PDSW Tools
ARM Ltd
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-10-12 8:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-10-11 16:30 [PATCH ARM] Fix unterminated list of options to 'set arm fallback-mode' and 'set arm force-mode' Matthew Gretton-Dann
2010-10-11 16:40 ` Daniel Jacobowitz
2010-10-12 8:47 ` Matthew Gretton-Dann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox