From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20951 invoked by alias); 12 Oct 2010 08:47:13 -0000 Received: (qmail 20942 invoked by uid 22791); 12 Oct 2010 08:47:12 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (217.140.96.50) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Oct 2010 08:47:05 +0000 Received: from cam-owa2.Emea.Arm.com (cam-owa2.emea.arm.com [10.1.105.18]) by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id o9C8hDF9029928; Tue, 12 Oct 2010 09:43:13 +0100 (BST) Received: from [10.1.77.49] ([10.1.255.212]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Tue, 12 Oct 2010 09:46:59 +0100 Subject: Re: [PATCH ARM] Fix unterminated list of options to 'set arm fallback-mode' and 'set arm force-mode' From: Matthew Gretton-Dann To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org In-Reply-To: <20101011164033.GA8459@caradoc.them.org> References: <1286814631.21020.10.camel@e102319-lin.cambridge.arm.com> <20101011164033.GA8459@caradoc.them.org> Content-Type: text/plain; charset="ISO-8859-1" Date: Tue, 12 Oct 2010 08:47:00 -0000 Message-ID: <1286873219.21020.11.camel@e102319-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-10/txt/msg00190.txt.bz2 On Mon, 2010-10-11 at 12:40 -0400, Daniel Jacobowitz wrote: > On Mon, Oct 11, 2010 at 05:30:31PM +0100, Matthew Gretton-Dann wrote: > > All, > > > > The attached patch adds a NULL entry at the end of the array of options > > accepted by 'set arm fallback-mode' and 'set arm force-mode'. Thus > > ensuring GDB doesn't go wandering off trying to print garbage from > > beyond the end of an array. > > > > Can someone please review and approve? > > Whoops, thank you. Committed. -- Matthew Gretton-Dann Principal Engineer - PDSW Tools ARM Ltd