[commit] updated gnulib from latest git.

[commit] updated gnulib from latest git.

[Pedro Alves]

Following up from:

 <http://sourceware.org/ml/gdb/2010-05/msg00069.html>

I've updated gnulib from latest git.

Funny enough, the memmem module no longer brings in
memcmp.c, which is what was giving Pierre troubles.

I've used gnulib-tool's --no-vc-files switch, so
one doesn't have to delete .cvsignore files manually.

Built and regtested on x86-64-unknown-linux-gnu.

Here's the change log of what I commited.

2010-05-23  Pedro Alves  <pedro@codesourcery.com>

	Update gnulib from latest git.
	(250b80067c1e1d8faa0c42fb572f721975b929c5)

	* gnulib/memcmp.c: Removed.
	* gnulib/memchr.valgrind: New.
	* gnulib/stddef.in.h: New.
	* gnulib/Makefile.am: Updated.
	* gnulib/memchr.c: Updated.
	* gnulib/memmem.c: Updated.
	* gnulib/stdint.in.h: Updated.
	* gnulib/str-two-way.h: Updated.
	* gnulib/string.in.h: Updated.
	* gnulib/wchar.in.h: Updated.

	* gnulib/extra/link-warning.h: Removed.
	* gnulib/extra/c++defs.h: New.
	* gnulib/extra/warn-on-use.h: New.
	* gnulib/extra/arg-nonnull.h: Updated.

	* gnulib/m4/extensions.m4: Updated.
	* gnulib/m4/gnulib-cache.m4: Updated.
	* gnulib/m4/gnulib-common.m4: Updated.
	* gnulib/m4/gnulib-comp.m4: Updated.
	* gnulib/m4/gnulib-tool.m4: Updated.
	* gnulib/m4/include_next.m4: Updated.
	* gnulib/m4/longlong.m4: Updated.
	* gnulib/m4/memchr.m4: Updated.
	* gnulib/m4/memmem.m4: Updated.
	* gnulib/m4/stdint.m4: Updated.
	* gnulib/m4/string_h.m4: Updated.
	* gnulib/m4/memcmp.m4: Removed.
	* gnulib/m4/onceonly_2_57.m4: Removed.
	* gnulib/m4/00gnulib.m4: New.
	* gnulib/m4/mmap-anon.m4: New.
	* gnulib/m4/multiarch.m4: New.
	* gnulib/m4/onceonly.m4: New.
	* gnulib/m4/stddef_h.m4: New.
	* gnulib/m4/warn-on-use.m4: New.
	* gnulib/m4/wchar.m4: Removed.
	* gnulib/m4/wchar_h.m4: New.
	* gnulib/m4/wchar_t.m4: New.
	* gnulib/m4/wint_t.m4: New.

	* aclocal.m4: Regenerate.
	* config.in: Likewise.
	* configure: Likewise.
	* gnulib/Makefile.in: Likewise.

2010-05-23  Pedro Alves  <pedro@codesourcery.com>

	gdb/gdbserver/
	* config.h: Regenerate.

-- 
Pedro Alves

Re: [commit] updated gnulib from latest git.

[Frédéric RISS]

Hi,

Le dimanche 23 mai 2010 à 02:40 +0100, Pedro Alves a écrit :
> Following up from:
> 
>  <http://sourceware.org/ml/gdb/2010-05/msg00069.html>
> 
> I've updated gnulib from latest git.

I don't understand all the specifics, but it seems there is something
broken in this commit. The commit contains the followig hunk in
gdb/config.in:

-/* Number of bits in a file offset, on hosts where this is settable. */
-#undef _FILE_OFFSET_BITS
-

This means that on a 32bits host the GDB part of the tree will get
compiled without large file support, while eg. bfd will be built with
that support. This in turn means that gdb functions that pass 'struct
stat *' to bfd functions will experience memory corruption. I've seen
crashes in sepdebug.exp due to that corruption.

Cheers,
Fred

Re: [commit] updated gnulib from latest git.

[Pedro Alves]

On Monday 24 May 2010 21:40:10, Frédéric RISS wrote:
> Hi,
> 
> Le dimanche 23 mai 2010 à 02:40 +0100, Pedro Alves a écrit :
> > Following up from:
> > 
> >  <http://sourceware.org/ml/gdb/2010-05/msg00069.html>
> > 
> > I've updated gnulib from latest git.
> 
> I don't understand all the specifics, but it seems there is something
> broken in this commit. The commit contains the followig hunk in
> gdb/config.in:
> 
> -/* Number of bits in a file offset, on hosts where this is settable. */
> -#undef _FILE_OFFSET_BITS
> -

How bizarre.  I don't know how that happened.  Maybe I used the wrong
version of autoconf/header.  Just regenerating the file brought
that back.

Thanks for finding and pointing this out.

-- 
Pedro Alves

Index: ChangeLog
===================================================================
RCS file: /cvs/src/src/gdb/ChangeLog,v
retrieving revision 1.11835
diff -u -p -u -p -r1.11835 ChangeLog
--- ChangeLog	23 May 2010 14:23:30 -0000	1.11835
+++ ChangeLog	24 May 2010 22:51:24 -0000
@@ -1,3 +1,7 @@
+2010-05-24  Pedro Alves  <pedro@codesourcery.com>
+
+	* config.in: Regenerate.
+
 2010-05-23  Jan Kratochvil  <jan.kratochvil@redhat.com>
 
 	Code cleanup.
Index: config.in
===================================================================
RCS file: /cvs/src/src/gdb/config.in,v
retrieving revision 1.117
diff -u -p -u -p -r1.117 config.in
--- config.in	23 May 2010 00:56:59 -0000	1.117
+++ config.in	24 May 2010 22:51:26 -0000
@@ -853,10 +853,16 @@
 # endif
 #endif
 
+/* Number of bits in a file offset, on hosts where this is settable. */
+#undef _FILE_OFFSET_BITS
+
 /* Define to 1 so <sys/proc.h> gets a definition of anon_hdl. Works around a
    <sys/proc.h> problem on IRIX 5. */
 #undef _KMEMUSER
 
+/* Define for large files, on AIX-style hosts. */
+#undef _LARGE_FILES
+
 /* Define to 1 if on MINIX. */
 #undef _MINIX
 

Re: [commit] updated gnulib from latest git.

[Frédéric RISS]

Le lundi 24 mai 2010 à 23:56 +0100, Pedro Alves a écrit :
> On Monday 24 May 2010 21:40:10, Frédéric RISS wrote:
> > I don't understand all the specifics, but it seems there is something
> > broken in this commit. The commit contains the followig hunk in
> > gdb/config.in:
> > 
> > -/* Number of bits in a file offset, on hosts where this is settable. */
> > -#undef _FILE_OFFSET_BITS
> > -
> 
> How bizarre.  I don't know how that happened.  Maybe I used the wrong
> version of autoconf/header.  Just regenerating the file brought
> that back.
> 
> Thanks for finding and pointing this out.

Thanks. For the record, I tried regenerating these myself and I got yet
another version, but which also didn't contain the large file support.
What version of the autotools are you using, isn't it 2.64?

Fred.

Re: [commit] updated gnulib from latest git.

[Pedro Alves]

On Tuesday 25 May 2010 06:14:27, Frédéric RISS wrote:
> Le lundi 24 mai 2010 à 23:56 +0100, Pedro Alves a écrit :
> > On Monday 24 May 2010 21:40:10, Frédéric RISS wrote:
> > > I don't understand all the specifics, but it seems there is something
> > > broken in this commit. The commit contains the followig hunk in
> > > gdb/config.in:
> > > 
> > > -/* Number of bits in a file offset, on hosts where this is settable. */
> > > -#undef _FILE_OFFSET_BITS
> > > -
> > 
> > How bizarre.  I don't know how that happened.  Maybe I used the wrong
> > version of autoconf/header.  Just regenerating the file brought
> > that back.
> > 
> > Thanks for finding and pointing this out.
> 
> Thanks. For the record, I tried regenerating these myself and I got yet
> another version, but which also didn't contain the large file support.
> What version of the autotools are you using, isn't it 2.64?

It is.  Pristine FSF 2.64 built from sources.

-- 
Pedro Alves