From: Richard Earnshaw <rearnsha@arm.com>
To: Matthew Gretton-Dann <matthew.gretton-dann@arm.com>,
Daniel Jacobowitz <dan@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH/ARM] Fix support of longjmp for ARM Linux.
Date: Thu, 29 Apr 2010 13:49:00 -0000 [thread overview]
Message-ID: <1272548983.28096.23.camel@e102346-lin.cambridge.arm.com> (raw)
In-Reply-To: <1272547868.19716.13.camel@e102111-lin.cambridge.arm.com>
On Thu, 2010-04-29 at 14:31 +0100, Matthew Gretton-Dann wrote:
> Hi,
>
> Can someone please review and comment on the attached patch?
>
> The patch fixes support for longjmp on ARM Linux. Dependent on the FP
> model in use the location of the PC to use as the long jump return value
> is stored in different locations in the long jump buffer. Currently gdb
> uses a hard-coded value which works for only one FP model, this patch
> corrects this.
>
> A suggested ChangeLog is:
>
> 2010-04-29 Matthew Gretton-Dann <matthew.gretton-dann@arm.com>
>
> * arm-linux-tdep.c (ARM_LINUX_JB_PC): Remove.
> (ARM_LINUX_JB_PC_FPA): Add, offset of PC in longjmp buffer for
> FPA.
> (ARM_LINUX_JP_PC_EABI): Add, offset of PC in longjmp buffer for
> EABI.
> (arm_linux_init_abi): Set up JB_PC field dependent on FP model
> in use.
>
> Thanks,
>
> Matt
This is ok.
Danniel, can we give Matt write-after a commit bit, please. He's
already got an account for binutils work.
R.
next prev parent reply other threads:[~2010-04-29 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 13:31 Matthew Gretton-Dann
2010-04-29 13:49 ` Richard Earnshaw [this message]
2010-04-29 14:36 ` Joel Brobecker
2010-04-29 16:36 ` Matthew Gretton-Dann
2010-05-03 22:57 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1272548983.28096.23.camel@e102346-lin.cambridge.arm.com \
--to=rearnsha@arm.com \
--cc=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=matthew.gretton-dann@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox