From: Daniel Jacobowitz <dan@codesourcery.com>
To: Richard Earnshaw <rearnsha@arm.com>
Cc: Matthew Gretton-Dann <matthew.gretton-dann@arm.com>,
gdb-patches@sourceware.org
Subject: Re: [PATCH/ARM] Fix support of longjmp for ARM Linux.
Date: Mon, 03 May 2010 22:57:00 -0000 [thread overview]
Message-ID: <20100503225712.GA8410@caradoc.them.org> (raw)
In-Reply-To: <1272548983.28096.23.camel@e102346-lin.cambridge.arm.com>
On Thu, Apr 29, 2010 at 02:49:43PM +0100, Richard Earnshaw wrote:
>
> On Thu, 2010-04-29 at 14:31 +0100, Matthew Gretton-Dann wrote:
> > Hi,
> >
> > Can someone please review and comment on the attached patch?
> >
> > The patch fixes support for longjmp on ARM Linux. Dependent on the FP
> > model in use the location of the PC to use as the long jump return value
> > is stored in different locations in the long jump buffer. Currently gdb
> > uses a hard-coded value which works for only one FP model, this patch
> > corrects this.
I'm not going to make a fuss, but for the record I am very weakly
opposed to this patch. The offset of PC in the longjmp buffer is
deliberately left implementation-private by the EABI. I'd rather we
got back to the generic (step-based or breakpoint-based rather than
jmp_buf-decoding-based) solution to longjmp.exp failures.
On the other hand, I can't see why this should hurt :-)
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2010-05-03 22:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 13:31 Matthew Gretton-Dann
2010-04-29 13:49 ` Richard Earnshaw
2010-04-29 14:36 ` Joel Brobecker
2010-04-29 16:36 ` Matthew Gretton-Dann
2010-05-03 22:57 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100503225712.GA8410@caradoc.them.org \
--to=dan@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=matthew.gretton-dann@arm.com \
--cc=rearnsha@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox