From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-72633-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 19601 invoked by alias); 29 Apr 2010 13:49:59 -0000
Received: (qmail 19589 invoked by uid 22791); 29 Apr 2010 13:49:58 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=BAYES_00,TW_GJ,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from cam-admin0.cambridge.arm.com (HELO cam-admin0.cambridge.arm.com) (217.140.96.50)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 29 Apr 2010 13:49:48 +0000
Received: from cam-owa1.Emea.Arm.com (cam-owa1.emea.arm.com [10.1.255.62])	by cam-admin0.cambridge.arm.com (8.12.6/8.12.6) with ESMTP id o3TDnheI007693;	Thu, 29 Apr 2010 14:49:43 +0100 (BST)
Received: from [10.1.69.50] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0);	 Thu, 29 Apr 2010 14:49:43 +0100
Subject: Re: [PATCH/ARM] Fix support of longjmp for ARM Linux.
From: Richard Earnshaw <rearnsha@arm.com>
To: Matthew Gretton-Dann <matthew.gretton-dann@arm.com>,   Daniel Jacobowitz <dan@codesourcery.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <1272547868.19716.13.camel@e102111-lin.cambridge.arm.com>
References: <1272547868.19716.13.camel@e102111-lin.cambridge.arm.com>
Content-Type: text/plain
Date: Thu, 29 Apr 2010 13:49:00 -0000
Message-Id: <1272548983.28096.23.camel@e102346-lin.cambridge.arm.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-04/txt/msg00952.txt.bz2


On Thu, 2010-04-29 at 14:31 +0100, Matthew Gretton-Dann wrote:
> Hi,
> 
> Can someone please review and comment on the attached patch?
> 
> The patch fixes support for longjmp on ARM Linux.  Dependent on the FP
> model in use the location of the PC to use as the long jump return value
> is stored in different locations in the long jump buffer.  Currently gdb
> uses a hard-coded value which works for only one FP model, this patch
> corrects this.
> 
> A suggested ChangeLog is:
> 
> 2010-04-29  Matthew Gretton-Dann  <matthew.gretton-dann@arm.com>
> 
> 	* arm-linux-tdep.c (ARM_LINUX_JB_PC): Remove.
> 	(ARM_LINUX_JB_PC_FPA): Add, offset of PC in longjmp buffer for 
> 	FPA.
> 	(ARM_LINUX_JP_PC_EABI): Add, offset of PC in longjmp buffer for 
> 	EABI.
> 	(arm_linux_init_abi): Set up JB_PC field dependent on FP model 
> 	in use.
> 
> Thanks,
> 
> Matt


This is ok.

Danniel, can we give Matt write-after a commit bit, please.  He's
already got an account for binutils work.

R.