Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Danny Backx <danny.backx@scarlet.be>
To: Joel Brobecker <brobecker@adacore.com>
Cc: Eli Zaretskii <eliz@gnu.org>, gdb-patches@sourceware.org
Subject: Re: Build question
Date: Tue, 08 Sep 2009 15:53:00 -0000	[thread overview]
Message-ID: <1252425273.6106.304.camel@pavilion> (raw)
In-Reply-To: <20090907221152.GL30677@adacore.com>

On Mon, 2009-09-07 at 15:11 -0700, Joel Brobecker wrote:
> > > +static inline int _isalpha(int c)
> > > +{ 
> > > +  if (c <= 'Z' && c >= 'A')
> > > +    return TRUE;
> > > +  if (c <= 'z' && c >= 'a')
> > > +    return TRUE;
> > > +  return FALSE;
> > > +}
> > 
> > I'm not sure what The Powers That Be think about defining inline
> > functions in a header.
> 
> As far as I am concerned, I would really like us to avoid them.
> In this case, is the author trying to achieve performance or
> to get a behavior that's independent from the locale?

They are slightly more readable than the equivalent macros.
I've converted my code to use macros already. I need to add code to it
(to set the option) before I submit a new version.

	Danny
-- 
Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info


  reply	other threads:[~2009-09-08 15:53 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1250803105.11282.96.camel@pavilion>
     [not found] ` <m3fxbl2jib.fsf@fleche.redhat.com>
     [not found]   ` <83d46pgjkq.fsf@gnu.org>
     [not found]     ` <1250877901.11282.116.camel@pavilion>
     [not found]       ` <83ab1tgh9h.fsf@gnu.org>
     [not found]         ` <1250880746.11282.128.camel@pavilion>
     [not found]           ` <m3r5v425lu.fsf@fleche.redhat.com>
     [not found]             ` <1250931899.11282.142.camel@pavilion>
     [not found]               ` <83skfkfa4n.fsf@gnu.org>
     [not found]                 ` <1251095160.16357.352.camel@pavilion>
     [not found]                   ` <1251828295.6106.119.camel@pavilion>
     [not found]                     ` <83zl9e8nro.fsf@gnu.org>
     [not found]                       ` <1251835928.6106.124.camel@pavilion>
     [not found]                         ` <83vdk281xb.fsf@gnu.org>
     [not found]                           ` <1252143311.6106.252.camel@pavilion>
2009-09-05 16:12                             ` Eli Zaretskii
2009-09-07 22:12                               ` Joel Brobecker
2009-09-08 15:53                                 ` Danny Backx [this message]
2009-09-08 20:13                               ` Danny Backx
2009-09-09 19:57                                 ` Tom Tromey
2009-09-11 14:41                                   ` Danny Backx
2009-09-11 15:22                                     ` Pedro Alves
2009-09-11 15:28                                       ` Pedro Alves
2009-09-12 14:48                                       ` Danny Backx
2009-09-12 15:03                                         ` Pedro Alves
2009-09-12 16:58                                           ` Danny Backx
2009-09-13 16:10                                             ` Pedro Alves
2009-09-13 18:07                                               ` Danny Backx
2009-09-12 14:53                                       ` Danny Backx
2009-09-13  9:30                                   ` Danny Backx
2009-09-13 16:04                                     ` Joel Brobecker
2009-09-14 18:03                                     ` Tom Tromey
2009-09-14 18:25                                       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252425273.6106.304.camel@pavilion \
    --to=danny.backx@scarlet.be \
    --cc=brobecker@adacore.com \
    --cc=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox