From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13078 invoked by alias); 8 Sep 2009 15:53:08 -0000 Received: (qmail 13024 invoked by uid 22791); 8 Sep 2009 15:53:06 -0000 X-SWARE-Spam-Status: No, hits=-0.6 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_55,RCVD_IN_DNSWL_LOW,RCVD_IN_JMF_BL,RCVD_IN_JMF_BR,SPF_PASS X-Spam-Check-By: sourceware.org Received: from eir.is.scarlet.be (HELO eir.is.scarlet.be) (193.74.71.27) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 08 Sep 2009 15:52:58 +0000 Received: from [172.17.1.10] (ip-81-11-242-151.dsl.scarlet.be [81.11.242.151]) by eir.is.scarlet.be (8.14.2/8.14.2) with ESMTP id n88FqRPF019813; Tue, 8 Sep 2009 17:52:27 +0200 Subject: Re: Build question From: Danny Backx Reply-To: danny.backx@scarlet.be To: Joel Brobecker Cc: Eli Zaretskii , gdb-patches@sourceware.org In-Reply-To: <20090907221152.GL30677@adacore.com> References: <1250931899.11282.142.camel@pavilion> <83skfkfa4n.fsf@gnu.org> <1251095160.16357.352.camel@pavilion> <1251828295.6106.119.camel@pavilion> <83zl9e8nro.fsf@gnu.org> <1251835928.6106.124.camel@pavilion> <83vdk281xb.fsf@gnu.org> <1252143311.6106.252.camel@pavilion> <83eiql4blw.fsf@gnu.org> <20090907221152.GL30677@adacore.com> Content-Type: text/plain Date: Tue, 08 Sep 2009 15:53:00 -0000 Message-Id: <1252425273.6106.304.camel@pavilion> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-DCC-scarlet.be-Metrics: eir 20001; Body=4 Fuz1=4 Fuz2=4 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-09/txt/msg00195.txt.bz2 On Mon, 2009-09-07 at 15:11 -0700, Joel Brobecker wrote: > > > +static inline int _isalpha(int c) > > > +{ > > > + if (c <= 'Z' && c >= 'A') > > > + return TRUE; > > > + if (c <= 'z' && c >= 'a') > > > + return TRUE; > > > + return FALSE; > > > +} > > > > I'm not sure what The Powers That Be think about defining inline > > functions in a header. > > As far as I am concerned, I would really like us to avoid them. > In this case, is the author trying to achieve performance or > to get a behavior that's independent from the locale? They are slightly more readable than the equivalent macros. I've converted my code to use macros already. I need to add code to it (to set the option) before I submit a new version. Danny -- Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info