From: John Baldwin <jhb@freebsd.org>
To: Joel Brobecker <brobecker@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Workaround a FreeBSD ptrace() bug with clearing thread events.
Date: Mon, 26 Feb 2018 17:25:00 -0000 [thread overview]
Message-ID: <12230993.oFNY2MVi4e@ralph.baldwin.cx> (raw)
In-Reply-To: <20180226042754.fthsp5demixbwq2l@adacore.com>
On Monday, February 26, 2018 08:27:54 AM Joel Brobecker wrote:
> Hi John,
>
> > gdb/ChangeLog:
> >
> > * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a
> > wildcard process pid for super_resume for kernels with a
> > specific bug.
>
> Just a small coding style nit:
>
> > +#if __FreeBSD_version < 1200052
> > + /*
> > + * When multiple threads within a process wish to report STOPPED
> > + * events from wait(), the kernel picks one thread event as the
>
> In the GDB project, we do not use the '*' at the start of every line.
> See:
>
> https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Block_Comment_Formatting
Oops, yes, I'll fix.
--
John Baldwin
next prev parent reply other threads:[~2018-02-26 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 0:10 John Baldwin
2018-02-26 4:28 ` Joel Brobecker
2018-02-26 17:25 ` John Baldwin [this message]
2018-03-02 0:51 ` Maciej W. Rozycki
2018-03-02 18:32 ` John Baldwin
2018-03-02 20:09 ` Maciej W. Rozycki
2018-03-02 22:48 ` John Baldwin
2018-03-03 17:45 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12230993.oFNY2MVi4e@ralph.baldwin.cx \
--to=jhb@freebsd.org \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox