From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50877 invoked by alias); 26 Feb 2018 17:25:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50861 invoked by uid 89); 26 Feb 2018 17:25:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=wish X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 26 Feb 2018 17:25:30 +0000 Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id AB07210AF2A; Mon, 26 Feb 2018 12:25:28 -0500 (EST) From: John Baldwin To: Joel Brobecker Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Workaround a FreeBSD ptrace() bug with clearing thread events. Date: Mon, 26 Feb 2018 17:25:00 -0000 Message-ID: <12230993.oFNY2MVi4e@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <20180226042754.fthsp5demixbwq2l@adacore.com> References: <20180224000935.43344-1-jhb@FreeBSD.org> <20180226042754.fthsp5demixbwq2l@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2018-02/txt/msg00387.txt.bz2 On Monday, February 26, 2018 08:27:54 AM Joel Brobecker wrote: > Hi John, > > > gdb/ChangeLog: > > > > * fbsd-nat.c (fbsd_resume): Use PT_SETSTEP for stepping and a > > wildcard process pid for super_resume for kernels with a > > specific bug. > > Just a small coding style nit: > > > +#if __FreeBSD_version < 1200052 > > + /* > > + * When multiple threads within a process wish to report STOPPED > > + * events from wait(), the kernel picks one thread event as the > > In the GDB project, we do not use the '*' at the start of every line. > See: > > https://sourceware.org/gdb/wiki/Internals%20GDB-C-Coding-Standards#Block_Comment_Formatting Oops, yes, I'll fix. -- John Baldwin