From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Jim Blandy <jimb@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [libiberty] don't demangle functions named "."
Date: Wed, 09 Jan 2008 19:55:00 -0000 [thread overview]
Message-ID: <1199908522.15225.59.camel@localhost.localdomain> (raw)
In-Reply-To: <m3abne6brw.fsf@codesourcery.com>
On Wed, 2008-01-09 at 11:26 -0800, Jim Blandy wrote:
> Thiago Jung Bauermann <bauerman at br.ibm.com> writes:
> > + if (demangle_function_name (work, mangled, declp, scan))
> > + {
> > + success = demangle_signature (work, mangled, declp);
> > + if (success)
> > + break;
> > + }
>
> Why not simply:
>
> if (demangle_function_name (work, mangled, declp, scan)
> && demangle_signature (work, mangled, declp))
> break;
success is used later on as the return value of the function. I can
change this to:
if (demangle_function_name (work, mangled, declp, scan)
&& demangle_signature (work, mangled, declp))
{
success = 1;
break;
}
--
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center
next prev parent reply other threads:[~2008-01-09 19:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-09 17:15 Thiago Jung Bauermann
2008-01-09 19:26 ` Jim Blandy
2008-01-09 19:55 ` Thiago Jung Bauermann [this message]
2008-01-19 3:02 ` Ian Lance Taylor
2008-01-23 1:05 ` Thiago Jung Bauermann
2008-01-23 5:03 ` Ben Elliston
2008-01-23 16:58 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1199908522.15225.59.camel@localhost.localdomain \
--to=bauerman@br.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=jimb@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox