From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-53182-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14850 invoked by alias); 9 Jan 2008 19:55:50 -0000
Received: (qmail 14837 invoked by uid 22791); 9 Jan 2008 19:55:49 -0000
X-Spam-Check-By: sourceware.org
Received: from igw1.br.ibm.com (HELO igw1.br.ibm.com) (32.104.18.24)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 09 Jan 2008 19:55:28 +0000
Received: from mailhub1.br.ibm.com (mailhub1 [9.18.232.109]) 	by igw1.br.ibm.com (Postfix) with ESMTP id 3B28B32C2CF 	for <gdb-patches@sourceware.org>; Wed,  9 Jan 2008 17:34:39 -0200 (BRDT)
Received: from d24av02.br.ibm.com (d24av02.br.ibm.com [9.18.232.47]) 	by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id m09JtNPY3723352 	for <gdb-patches@sourceware.org>; Wed, 9 Jan 2008 17:55:23 -0200
Received: from d24av02.br.ibm.com (loopback [127.0.0.1]) 	by d24av02.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m09JtMqW008066 	for <gdb-patches@sourceware.org>; Wed, 9 Jan 2008 17:55:23 -0200
Received: from [9.18.238.251] ([9.18.238.251]) 	by d24av02.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id m09JtMV3008063; 	Wed, 9 Jan 2008 17:55:22 -0200
Subject: Re: [libiberty] don't demangle functions named "."
From: Thiago Jung Bauermann <bauerman@br.ibm.com>
To: Jim Blandy <jimb@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,         gdb-patches <gdb-patches@sourceware.org>
In-Reply-To: <m3abne6brw.fsf@codesourcery.com>
References: <1199898911.15225.48.camel@localhost.localdomain> 	 <m3abne6brw.fsf@codesourcery.com>
Content-Type: text/plain
Date: Wed, 09 Jan 2008 19:55:00 -0000
Message-Id: <1199908522.15225.59.camel@localhost.localdomain>
Mime-Version: 1.0
X-Mailer: Evolution 2.12.2
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-01/txt/msg00214.txt.bz2

On Wed, 2008-01-09 at 11:26 -0800, Jim Blandy wrote:
> Thiago Jung Bauermann <bauerman at br.ibm.com> writes:
> > +      if (demangle_function_name (work, mangled, declp, scan))
> > +	{
> > +	  success = demangle_signature (work, mangled, declp);
> > +	  if (success)
> > +	    break;
> > +	}
> 
> Why not simply:
> 
>       if (demangle_function_name (work, mangled, declp, scan)
>           && demangle_signature (work, mangled, declp))
>         break;

success is used later on as the return value of the function. I can
change this to:

      if (demangle_function_name (work, mangled, declp, scan)
	  && demangle_signature (work, mangled, declp))
	{
	  success = 1;
	  break;
	}

-- 
[]'s
Thiago Jung Bauermann
Software Engineer
IBM Linux Technology Center