Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jim Blandy <jimb@codesourcery.com>
To: Thiago Jung Bauermann <bauerman@br.ibm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>,
		  gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [libiberty] don't demangle functions named "."
Date: Wed, 09 Jan 2008 19:26:00 -0000	[thread overview]
Message-ID: <m3abne6brw.fsf@codesourcery.com> (raw)
In-Reply-To: <1199898911.15225.48.camel@localhost.localdomain> (Thiago Jung Bauermann's message of "Wed, 09 Jan 2008 15:15:11 -0200")


Thiago Jung Bauermann <bauerman at br.ibm.com> writes:
> @@ -2513,10 +2510,12 @@ iterate_demangle_function (struct work_s
>  
>    while (scan[2])
>      {
> -      demangle_function_name (work, mangled, declp, scan);
> -      success = demangle_signature (work, mangled, declp);
> -      if (success)
> -	break;
> +      if (demangle_function_name (work, mangled, declp, scan))
> +	{
> +	  success = demangle_signature (work, mangled, declp);
> +	  if (success)
> +	    break;
> +	}
>  
>        /* Reset demangle state for the next round.  */
>        *mangled = mangle_init;

Why not simply:

      if (demangle_function_name (work, mangled, declp, scan)
          && demangle_signature (work, mangled, declp))
        break;


  reply	other threads:[~2008-01-09 19:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09 17:15 Thiago Jung Bauermann
2008-01-09 19:26 ` Jim Blandy [this message]
2008-01-09 19:55   ` Thiago Jung Bauermann
2008-01-19  3:02 ` Ian Lance Taylor
2008-01-23  1:05   ` Thiago Jung Bauermann
2008-01-23  5:03     ` Ben Elliston
2008-01-23 16:58       ` Thiago Jung Bauermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3abne6brw.fsf@codesourcery.com \
    --to=jimb@codesourcery.com \
    --cc=bauerman@br.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox