From: Luis Machado <luisgpm@linux.vnet.ibm.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Watchpoints + conditionals problem
Date: Mon, 17 Dec 2007 11:35:00 -0000 [thread overview]
Message-ID: <1197890615.24027.1.camel@gargoyle> (raw)
In-Reply-To: <20071216214500.GD2618@caradoc.them.org>
Thanks Daniel.
On Sun, 2007-12-16 at 16:45 -0500, Daniel Jacobowitz wrote:
> On Wed, Nov 28, 2007 at 03:59:15PM -0200, Luis Machado wrote:
> > Index: gdb/breakpoint.c
> > ===================================================================
> > --- gdb.orig/breakpoint.c 2007-11-28 09:47:26.000000000 -0800
> > +++ gdb/breakpoint.c 2007-11-28 09:49:47.000000000 -0800
> > @@ -2969,7 +2969,7 @@
> > if (b->type == bp_watchpoint_scope)
> > b->related_breakpoint->watchpoint_triggered = watch_triggered_yes;
> >
> > - if (bl->cond)
> > + if (bl->cond && bl->owner->disposition != disp_del_at_next_stop)
> > {
> > /* Need to select the frame, with all that implies
> > so that the conditions will have the right context. */
>
> Seems OK to me.
>
--
Luis Machado
Software Engineer
IBM Linux Technology Center
LoP Toolchain/Debuggers' team
Phone: +55 19-2132-2218
T/L: 839-2218
e-mail: luisgpm@linux.vnet.ibm.com
next prev parent reply other threads:[~2007-12-17 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-28 17:59 Luis Machado
2007-11-29 8:54 ` Vladimir Prus
2007-11-29 12:06 ` Luis Machado
2007-12-16 21:48 ` Daniel Jacobowitz
2007-12-17 11:35 ` Luis Machado [this message]
2007-12-17 12:36 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1197890615.24027.1.camel@gargoyle \
--to=luisgpm@linux.vnet.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox