From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32352 invoked by alias); 17 Dec 2007 11:23:49 -0000 Received: (qmail 32342 invoked by uid 22791); 17 Dec 2007 11:23:48 -0000 X-Spam-Check-By: sourceware.org Received: from igw2.br.ibm.com (HELO igw2.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Dec 2007 11:23:40 +0000 Received: from mailhub1.br.ibm.com (mailhub1 [9.18.232.109]) by igw2.br.ibm.com (Postfix) with ESMTP id 1ED9717F5E6 for ; Mon, 17 Dec 2007 09:18:52 -0200 (BRDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v8.7) with ESMTP id lBHBNZDh3895444 for ; Mon, 17 Dec 2007 09:23:35 -0200 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id lBHBNZ33006094 for ; Mon, 17 Dec 2007 09:23:35 -0200 Received: from [9.8.1.101] ([9.8.1.101]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id lBHBNYvf006079 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 17 Dec 2007 09:23:35 -0200 Subject: Re: [PATCH] Watchpoints + conditionals problem From: Luis Machado Reply-To: luisgpm@linux.vnet.ibm.com To: Daniel Jacobowitz Cc: gdb-patches@sourceware.org In-Reply-To: <20071216214500.GD2618@caradoc.them.org> References: <1196272755.15925.11.camel@gargoyle> <20071216214500.GD2618@caradoc.them.org> Content-Type: text/plain Date: Mon, 17 Dec 2007 11:35:00 -0000 Message-Id: <1197890615.24027.1.camel@gargoyle> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-12/txt/msg00264.txt.bz2 Thanks Daniel. On Sun, 2007-12-16 at 16:45 -0500, Daniel Jacobowitz wrote: > On Wed, Nov 28, 2007 at 03:59:15PM -0200, Luis Machado wrote: > > Index: gdb/breakpoint.c > > =================================================================== > > --- gdb.orig/breakpoint.c 2007-11-28 09:47:26.000000000 -0800 > > +++ gdb/breakpoint.c 2007-11-28 09:49:47.000000000 -0800 > > @@ -2969,7 +2969,7 @@ > > if (b->type == bp_watchpoint_scope) > > b->related_breakpoint->watchpoint_triggered = watch_triggered_yes; > > > > - if (bl->cond) > > + if (bl->cond && bl->owner->disposition != disp_del_at_next_stop) > > { > > /* Need to select the frame, with all that implies > > so that the conditions will have the right context. */ > > Seems OK to me. > -- Luis Machado Software Engineer IBM Linux Technology Center LoP Toolchain/Debuggers' team Phone: +55 19-2132-2218 T/L: 839-2218 e-mail: luisgpm@linux.vnet.ibm.com