From: Luis Machado <luisgpm@linux.vnet.ibm.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] Backtrace prints wrong argument value
Date: Mon, 17 Sep 2007 13:30:00 -0000 [thread overview]
Message-ID: <1190035779.4651.16.camel@localhost> (raw)
In-Reply-To: <20070917131542.GA12835@caradoc.them.org>
From the mail body it's doubled, it seems, due to my mailer. Did you try
to just save the attached file? That works correct for me, and it's the
only way i can trust it will work right.
If that doesn't work, let me know and i'll submit again in a different
way.
Regards
On Mon, 2007-09-17 at 09:15 -0400, Daniel Jacobowitz wrote:
> On Mon, Sep 17, 2007 at 10:04:38AM -0300, Luis Machado wrote:
> >
> > Daniel,
> >
> > Thanks for reviewing.
> >
> > Yeah, i definitely had issues with my editor and the tabs ended up being
> > expanded to spaces. Hopefully this version is correct now. I hope my
> > mail client doesn't mess the tabs.
>
> Ouch, this one's even worse. All your tabs were doubled. I've never
> seen that happen before.
> > @@ -3774,6 +3836,9 @@
> > frame_unwind_append_sniffer (gdbarch, dwarf2_frame_sniffer);
> > dwarf2_frame_set_adjust_regnum (gdbarch, rs6000_adjust_frame_regnum);
> >
> > + /* Frame handling. */
> > + dwarf2_frame_set_init_reg (gdbarch, ppc_dwarf2_frame_init_reg);
> > +
> > /* Hook in ABI-specific overrides, if they have been registered. */
> > gdbarch_init_osabi (info, gdbarch);
> >
>
> Not sure why there's a tab in that - mailer trouble again? Above and
> below are indented with only two spaces.
>
> > @@ -3790,6 +3855,7 @@
> > tdep->ppc_vr0_regnum = 71;
> > tdep->ppc_vrsave_regnum = 104;
> > }
> > +
> > /* Fall Thru */
> > case GDB_OSABI_NETBSD_AOUT:
> > case GDB_OSABI_NETBSD_ELF:
>
> Stray blank line here.
>
--
Luis Machado
IBM Linux Technology Center
e-mail: luisgpm@linux.vnet.ibm.com
next prev parent reply other threads:[~2007-09-17 13:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 19:13 Luis Machado
2007-04-25 19:25 ` Daniel Jacobowitz
2007-04-25 22:28 ` Luis Machado
2007-04-30 13:31 ` Luis Machado
2007-05-16 5:34 ` Luis Machado
2007-05-16 14:43 ` Daniel Jacobowitz
2007-05-16 15:20 ` Luis Machado
2007-05-16 15:23 ` Daniel Jacobowitz
2007-09-13 14:47 ` Luis Machado
2007-09-16 19:45 ` Daniel Jacobowitz
2007-09-17 13:05 ` Luis Machado
2007-09-17 13:15 ` Daniel Jacobowitz
2007-09-17 13:30 ` Luis Machado [this message]
2007-09-17 13:37 ` Daniel Jacobowitz
2007-09-17 13:46 ` Luis Machado
2007-09-17 14:00 ` Luis Machado
2007-09-17 14:04 ` Daniel Jacobowitz
2007-09-17 16:02 ` Luis Machado
2007-09-17 17:15 ` Luis Machado
2007-09-17 17:18 ` Daniel Jacobowitz
2007-09-17 17:34 ` Luis Machado
2007-09-17 17:48 ` Daniel Jacobowitz
2007-10-03 14:58 ` Luis Machado
2007-10-21 21:41 ` Luis Machado
2007-10-22 0:03 ` Joel Brobecker
2007-10-22 1:20 ` Daniel Jacobowitz
2007-10-22 4:11 ` Joel Brobecker
2007-10-24 20:50 ` Daniel Jacobowitz
2007-10-24 20:59 ` Joel Brobecker
2007-10-24 21:01 ` Daniel Jacobowitz
2007-10-24 22:23 ` Pedro Alves
2007-10-24 22:38 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1190035779.4651.16.camel@localhost \
--to=luisgpm@linux.vnet.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox