From: "Pedro Alves" <pedro_alves@portugalmail.pt>
To: "Joel Brobecker" <brobecker@adacore.com>,
"Luis Machado" <luisgpm@linux.vnet.ibm.com>,
gdb-patches@sources.redhat.com
Subject: Re: [patch] Backtrace prints wrong argument value
Date: Wed, 24 Oct 2007 22:23:00 -0000 [thread overview]
Message-ID: <4053daab0710241514s3a94f1fds6ef17c226546ccc4@mail.gmail.com> (raw)
In-Reply-To: <20071024204654.GP10943@caradoc.them.org>
Daniel Jacobowitz wrote:
> With Pedro's help, two are now fixed. Only build/2339 remains. But
> that's with SunPro and I don't think it's a blocker - so we are
> probably good to go now.
>
Irk. I've seen that happen too a few months ago, but totally forgot
about it. That happens due to the your's trully and Nick's
new STRING_COMMA_LEN in bfd.
bfd-in.h:#define STRING_COMMA_LEN(STR) (STR), ((STR) ? sizeof (STR) - 1 : 0)
SunPro doesn't like the '?' operator for constant initilizers.
elf.c", line 856: non-constant initializer: op "?"
The fix is easy - inline the STRING_COMMA_LEN(NULL) cases.
Wait, a quick 'grep STRING_COMMA_LEN * -rn | grep NULL' shows
there aren't any?
This should fix it. I'll see if I can give it a spin with SunPro this week, but
no promises.
-#define STRING_COMMA_LEN(STR) (STR), ((STR) ? sizeof (STR) - 1 : 0)
+#define STRING_COMMA_LEN(STR) (STR), (sizeof (STR) - 1)
Cheers,
Pedro Alves
next prev parent reply other threads:[~2007-10-24 22:14 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-25 19:13 Luis Machado
2007-04-25 19:25 ` Daniel Jacobowitz
2007-04-25 22:28 ` Luis Machado
2007-04-30 13:31 ` Luis Machado
2007-05-16 5:34 ` Luis Machado
2007-05-16 14:43 ` Daniel Jacobowitz
2007-05-16 15:20 ` Luis Machado
2007-05-16 15:23 ` Daniel Jacobowitz
2007-09-13 14:47 ` Luis Machado
2007-09-16 19:45 ` Daniel Jacobowitz
2007-09-17 13:05 ` Luis Machado
2007-09-17 13:15 ` Daniel Jacobowitz
2007-09-17 13:30 ` Luis Machado
2007-09-17 13:37 ` Daniel Jacobowitz
2007-09-17 13:46 ` Luis Machado
2007-09-17 14:00 ` Luis Machado
2007-09-17 14:04 ` Daniel Jacobowitz
2007-09-17 16:02 ` Luis Machado
2007-09-17 17:15 ` Luis Machado
2007-09-17 17:18 ` Daniel Jacobowitz
2007-09-17 17:34 ` Luis Machado
2007-09-17 17:48 ` Daniel Jacobowitz
2007-10-03 14:58 ` Luis Machado
2007-10-21 21:41 ` Luis Machado
2007-10-22 0:03 ` Joel Brobecker
2007-10-22 1:20 ` Daniel Jacobowitz
2007-10-22 4:11 ` Joel Brobecker
2007-10-24 20:50 ` Daniel Jacobowitz
2007-10-24 20:59 ` Joel Brobecker
2007-10-24 21:01 ` Daniel Jacobowitz
2007-10-24 22:23 ` Pedro Alves [this message]
2007-10-24 22:38 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4053daab0710241514s3a94f1fds6ef17c226546ccc4@mail.gmail.com \
--to=pedro_alves@portugalmail.pt \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sources.redhat.com \
--cc=luisgpm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox