From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24375 invoked by alias); 17 Sep 2007 13:30:14 -0000 Received: (qmail 24326 invoked by uid 22791); 17 Sep 2007 13:30:13 -0000 X-Spam-Check-By: sourceware.org Received: from igw2.br.ibm.com (HELO igw2.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Sep 2007 13:30:01 +0000 Received: from mailhub3.br.ibm.com (mailhub3 [9.18.232.110]) by igw2.br.ibm.com (Postfix) with ESMTP id CA85317F53C for ; Mon, 17 Sep 2007 10:28:00 -0300 (BRT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub3.br.ibm.com (8.13.8/8.13.8/NCO v8.5) with ESMTP id l8HDTtmj2990236 for ; Mon, 17 Sep 2007 10:29:56 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l8HDThBC026836 for ; Mon, 17 Sep 2007 10:29:51 -0300 Received: from [9.18.238.24] ([9.18.238.24]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l8HDTeXc026749; Mon, 17 Sep 2007 10:29:41 -0300 Subject: Re: [patch] Backtrace prints wrong argument value From: Luis Machado Reply-To: luisgpm@linux.vnet.ibm.com To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com In-Reply-To: <20070917131542.GA12835@caradoc.them.org> References: <1177527233.12599.42.camel@localhost> <20070425191304.GA1283@caradoc.them.org> <1179293640.4323.16.camel@localhost> <20070516144250.GD24682@caradoc.them.org> <1189694765.4564.5.camel@localhost> <20070916194510.GC27177@caradoc.them.org> <1190034278.4651.10.camel@localhost> <20070917131542.GA12835@caradoc.them.org> Content-Type: text/plain Date: Mon, 17 Sep 2007 13:30:00 -0000 Message-Id: <1190035779.4651.16.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-09/txt/msg00218.txt.bz2 >From the mail body it's doubled, it seems, due to my mailer. Did you try to just save the attached file? That works correct for me, and it's the only way i can trust it will work right. If that doesn't work, let me know and i'll submit again in a different way. Regards On Mon, 2007-09-17 at 09:15 -0400, Daniel Jacobowitz wrote: > On Mon, Sep 17, 2007 at 10:04:38AM -0300, Luis Machado wrote: > > > > Daniel, > > > > Thanks for reviewing. > > > > Yeah, i definitely had issues with my editor and the tabs ended up being > > expanded to spaces. Hopefully this version is correct now. I hope my > > mail client doesn't mess the tabs. > > Ouch, this one's even worse. All your tabs were doubled. I've never > seen that happen before. > > @@ -3774,6 +3836,9 @@ > > frame_unwind_append_sniffer (gdbarch, dwarf2_frame_sniffer); > > dwarf2_frame_set_adjust_regnum (gdbarch, rs6000_adjust_frame_regnum); > > > > + /* Frame handling. */ > > + dwarf2_frame_set_init_reg (gdbarch, ppc_dwarf2_frame_init_reg); > > + > > /* Hook in ABI-specific overrides, if they have been registered. */ > > gdbarch_init_osabi (info, gdbarch); > > > > Not sure why there's a tab in that - mailer trouble again? Above and > below are indented with only two spaces. > > > @@ -3790,6 +3855,7 @@ > > tdep->ppc_vr0_regnum = 71; > > tdep->ppc_vrsave_regnum = 104; > > } > > + > > /* Fall Thru */ > > case GDB_OSABI_NETBSD_AOUT: > > case GDB_OSABI_NETBSD_ELF: > > Stray blank line here. > -- Luis Machado IBM Linux Technology Center e-mail: luisgpm@linux.vnet.ibm.com