[patch] Fix assorted typos

[patch] Fix assorted typos

[Luis Machado]

[-- Attachment #1: Type: text/plain, Size: 122 bytes --]

Hi,

I've been through the internal documentation and have found a few typos.
This patch fixes those.

Best regards,
Luis

[-- Attachment #2: typos.diff --]
[-- Type: text/x-patch, Size: 5092 bytes --]

diff --git a/gdb/block.h b/gdb/block.h
index 1158dc6..59bbe03 100644
--- a/gdb/block.h
+++ b/gdb/block.h
@@ -105,7 +105,7 @@ struct block
      reading.  As of 16 Apr 93, this flag is never used to distinguish
      between gcc2 and the native compiler.
 
-     If there is no function corresponding to this block, this meaning
+     If there is no function corresponding to this block, the meaning
      of this flag is undefined.  */
 
   unsigned char gcc_compile_flag;
diff --git a/gdb/dwarf2expr.h b/gdb/dwarf2expr.h
index c1adf9a..37c1883 100644
--- a/gdb/dwarf2expr.h
+++ b/gdb/dwarf2expr.h
@@ -46,7 +46,7 @@ struct dwarf_expr_context
   void (*read_mem) (void *baton, gdb_byte *buf, CORE_ADDR addr, size_t length);
 
   /* Return the location expression for the frame base attribute, in
-     START and LENGTH.  The result must be live until the current
+     START and LENGTH.  The result must live until the current
      expression evaluation is complete.  */
   void (*get_frame_base) (void *baton, gdb_byte **start, size_t *length);
 
@@ -59,7 +59,7 @@ struct dwarf_expr_context
 
   /* Return the location expression for the dwarf expression
      subroutine in the die at OFFSET in the current compilation unit.
-     The result must be live until the current expression evaluation
+     The result must live until the current expression evaluation
      is complete.  */
   unsigned char *(*get_subr) (void *baton, off_t offset, size_t *length);
 
diff --git a/gdb/dwarf2loc.c b/gdb/dwarf2loc.c
index 1e6ff67..0967da5 100644
--- a/gdb/dwarf2loc.c
+++ b/gdb/dwarf2loc.c
@@ -546,7 +546,7 @@ loclist_read_variable (struct symbol *symbol, struct frame_info *frame)
   return val;
 }
 
-/* Return non-zero iff we need a frame to evaluate SYMBOL.  */
+/* Return non-zero if we need a frame to evaluate SYMBOL.  */
 static int
 loclist_read_needs_frame (struct symbol *symbol)
 {
diff --git a/gdb/frame-unwind.h b/gdb/frame-unwind.h
index e1ac871..de7fc7e 100644
--- a/gdb/frame-unwind.h
+++ b/gdb/frame-unwind.h
@@ -33,8 +33,8 @@ struct regcache;
 
 /* The following unwind functions assume a chain of frames forming the
    sequence: (outer) prev <-> this <-> next (inner).  All the
-   functions are called with called with the next frame's `struct
-   frame_info' and and this frame's prologue cache.
+   functions are called with the next frame's `struct
+   frame_info' and this frame's prologue cache.
 
    THIS frame's register values can be obtained by unwinding NEXT
    frame's registers (a recursive operation).
diff --git a/gdb/frame.c b/gdb/frame.c
index d066a49..d3eb716 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -1502,7 +1502,7 @@ frame_unwind_address_in_block (struct frame_info *next_frame,
 
   /* If THIS frame is not inner most (i.e., NEXT isn't the sentinel),
      and NEXT is `normal' (i.e., not a sigtramp, dummy, ....) THIS
-     frame's PC ends up pointing at the instruction fallowing the
+     frame's PC ends up pointing at the instruction following the
      "call".  Adjust that PC value so that it falls on the call
      instruction (which, hopefully, falls within THIS frame's code
      block).  So far it's proved to be a very good approximation.  See
diff --git a/gdb/parse.c b/gdb/parse.c
index af3ef72..60b5a4f 100644
--- a/gdb/parse.c
+++ b/gdb/parse.c
@@ -1076,7 +1076,7 @@ prefixify_subexp (struct expression *inexpr,
 \f
 /* This page contains the two entry points to this file.  */
 
-/* Read an expression from the string *STRINGPTR points to,
+/* Read an expression from the string pointed by *STRINGPTR,
    parse it, and return a pointer to a  struct expression  that we malloc.
    Use block BLOCK as the lexical context for variable names;
    if BLOCK is zero, use the block of the selected stack frame.
diff --git a/gdb/symtab.h b/gdb/symtab.h
index cefb0ad..ee61a98 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -640,7 +640,7 @@ struct symbol
   const struct symbol_ops *ops;
 
   /* Some symbols require additional information to be recorded on a
-     per- symbol basis.  Stash those values here. */
+     per-symbol basis.  Stash those values here. */
 
   union
   {
@@ -649,7 +649,7 @@ struct symbol
     /* An arbitrary data pointer.  Note that this data must be
        allocated using the same obstack as the symbol itself.  */
     /* So far it is only used by LOC_COMPUTED and LOC_COMPUTED_ARG to
-       find the location location information.  For a LOC_BLOCK symbol
+       find the location information.  For a LOC_BLOCK symbol
        for a function in a compilation unit compiled with DWARF 2
        information, this is information used internally by the DWARF 2
        code --- specifically, the location expression for the frame
diff --git a/gdb/value.c b/gdb/value.c
index 26ba2a4..a88afa4 100644
--- a/gdb/value.c
+++ b/gdb/value.c
@@ -240,7 +240,7 @@ allocate_value (struct type *type)
 }
 
 /* Allocate a  value  that has the correct length
-   for COUNT repetitions type TYPE.  */
+   for COUNT repetitions of type TYPE.  */
 
 struct value *
 allocate_repeat_value (struct type *type, int count)

Re: [patch] Fix assorted typos

[Luis Machado]

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

Oops, this was an early version. Updated patch follows.

Luis
On Thu, 2007-05-31 at 09:09 -0300, Luis Machado wrote:
> Hi,
> 
> I've been through the internal documentation and have found a few typos.
> This patch fixes those.
> 
> Best regards,
> Luis

[-- Attachment #2: typos.diff --]
[-- Type: text/x-patch, Size: 5211 bytes --]

2007-05-31  Luis Machado  <luisgpm@br.ibm.com>

    * block.h: Fixed documentation typo.
    * dwarf2expr.h: Likewise.
    * frame-unwind.h: Likewise.
    * frame.c: Likewise.
    * parse.c: Likewise.
    * value.c: Likewise.
    * symtab.h: Likewise.

Index: block.h
===================================================================
--- block.h.orig	2007-05-31 04:57:13.000000000 -0700
+++ block.h	2007-05-31 05:02:09.000000000 -0700
@@ -105,7 +105,7 @@
      reading.  As of 16 Apr 93, this flag is never used to distinguish
      between gcc2 and the native compiler.
 
-     If there is no function corresponding to this block, this meaning
+     If there is no function corresponding to this block, the meaning
      of this flag is undefined.  */
 
   unsigned char gcc_compile_flag;
Index: dwarf2expr.h
===================================================================
--- dwarf2expr.h.orig	2007-05-31 04:57:13.000000000 -0700
+++ dwarf2expr.h	2007-05-31 05:02:09.000000000 -0700
@@ -46,7 +46,7 @@
   void (*read_mem) (void *baton, gdb_byte *buf, CORE_ADDR addr, size_t length);
 
   /* Return the location expression for the frame base attribute, in
-     START and LENGTH.  The result must be live until the current
+     START and LENGTH.  The result must live until the current
      expression evaluation is complete.  */
   void (*get_frame_base) (void *baton, gdb_byte **start, size_t *length);
 
@@ -59,7 +59,7 @@
 
   /* Return the location expression for the dwarf expression
      subroutine in the die at OFFSET in the current compilation unit.
-     The result must be live until the current expression evaluation
+     The result must live until the current expression evaluation
      is complete.  */
   unsigned char *(*get_subr) (void *baton, off_t offset, size_t *length);
 
Index: frame-unwind.h
===================================================================
--- frame-unwind.h.orig	2007-05-31 04:57:13.000000000 -0700
+++ frame-unwind.h	2007-05-31 05:02:09.000000000 -0700
@@ -33,8 +33,8 @@
 
 /* The following unwind functions assume a chain of frames forming the
    sequence: (outer) prev <-> this <-> next (inner).  All the
-   functions are called with called with the next frame's `struct
-   frame_info' and and this frame's prologue cache.
+   functions are called with the next frame's `struct
+   frame_info' and this frame's prologue cache.
 
    THIS frame's register values can be obtained by unwinding NEXT
    frame's registers (a recursive operation).
Index: frame.c
===================================================================
--- frame.c.orig	2007-05-31 04:57:13.000000000 -0700
+++ frame.c	2007-05-31 05:02:09.000000000 -0700
@@ -1502,7 +1502,7 @@
 
   /* If THIS frame is not inner most (i.e., NEXT isn't the sentinel),
      and NEXT is `normal' (i.e., not a sigtramp, dummy, ....) THIS
-     frame's PC ends up pointing at the instruction fallowing the
+     frame's PC ends up pointing at the instruction following the
      "call".  Adjust that PC value so that it falls on the call
      instruction (which, hopefully, falls within THIS frame's code
      block).  So far it's proved to be a very good approximation.  See
Index: parse.c
===================================================================
--- parse.c.orig	2007-05-31 04:57:13.000000000 -0700
+++ parse.c	2007-05-31 05:02:09.000000000 -0700
@@ -1076,7 +1076,7 @@
 \f
 /* This page contains the two entry points to this file.  */
 
-/* Read an expression from the string *STRINGPTR points to,
+/* Read an expression from the string pointed to by *STRINGPTR,
    parse it, and return a pointer to a  struct expression  that we malloc.
    Use block BLOCK as the lexical context for variable names;
    if BLOCK is zero, use the block of the selected stack frame.
Index: symtab.h
===================================================================
--- symtab.h.orig	2007-05-31 04:57:13.000000000 -0700
+++ symtab.h	2007-05-31 05:02:09.000000000 -0700
@@ -640,7 +640,7 @@
   const struct symbol_ops *ops;
 
   /* Some symbols require additional information to be recorded on a
-     per- symbol basis.  Stash those values here. */
+     per-symbol basis.  Stash those values here. */
 
   union
   {
@@ -649,7 +649,7 @@
     /* An arbitrary data pointer.  Note that this data must be
        allocated using the same obstack as the symbol itself.  */
     /* So far it is only used by LOC_COMPUTED and LOC_COMPUTED_ARG to
-       find the location location information.  For a LOC_BLOCK symbol
+       find the location information.  For a LOC_BLOCK symbol
        for a function in a compilation unit compiled with DWARF 2
        information, this is information used internally by the DWARF 2
        code --- specifically, the location expression for the frame
Index: value.c
===================================================================
--- value.c.orig	2007-05-31 04:57:13.000000000 -0700
+++ value.c	2007-05-31 05:02:09.000000000 -0700
@@ -240,7 +240,7 @@
 }
 
 /* Allocate a  value  that has the correct length
-   for COUNT repetitions type TYPE.  */
+   for COUNT repetitions of type TYPE.  */
 
 struct value *
 allocate_repeat_value (struct type *type, int count)

Re: [patch] Fix assorted typos

[Markus Deuling]

Hi Luis,
I have two small comments.

>> Index: frame-unwind.h
>> ===================================================================
>> --- frame-unwind.h.orig	2007-05-31 04:57:13.000000000 -0700
>> +++ frame-unwind.h	2007-05-31 05:02:09.000000000 -0700
>> @@ -33,8 +33,8 @@
>>  
>>  /* The following unwind functions assume a chain of frames forming the
>>     sequence: (outer) prev <-> this <-> next (inner).  All the
>> -   functions are called with called with the next frame's `struct
>> -   frame_info' and and this frame's prologue cache.
>> +   functions are called with the next frame's `struct
>> +   frame_info' and this frame's prologue cache.

`struct frame_info'  The first and last character are different.


>> Index: parse.c
>> ===================================================================
>> --- parse.c.orig	2007-05-31 04:57:13.000000000 -0700
>> +++ parse.c	2007-05-31 05:02:09.000000000 -0700
>> @@ -1076,7 +1076,7 @@
>>  \f
Maybe it's a problem of my mail reader, but I see a kind of special character here ?!?





-- 
Markus Deuling
GNU Toolchain for Linux on Cell BE
deuling@de.ibm.com

Re: [patch] Fix assorted typos

[Luis Machado]

[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]

Markus,

You are right. I've corrected the first and last character. 

As for the strange character, it's part of the context line from GDB's
source. It's a ^L character.

Best regards,
Luis

On Thu, 2007-05-31 at 14:38 +0200, Markus Deuling wrote:
> Hi Luis,
> I have two small comments.
> 
> >> Index: frame-unwind.h
> >> ===================================================================
> >> --- frame-unwind.h.orig	2007-05-31 04:57:13.000000000 -0700
> >> +++ frame-unwind.h	2007-05-31 05:02:09.000000000 -0700
> >> @@ -33,8 +33,8 @@
> >>  
> >>  /* The following unwind functions assume a chain of frames forming the
> >>     sequence: (outer) prev <-> this <-> next (inner).  All the
> >> -   functions are called with called with the next frame's `struct
> >> -   frame_info' and and this frame's prologue cache.
> >> +   functions are called with the next frame's `struct
> >> +   frame_info' and this frame's prologue cache.
> 
> `struct frame_info'  The first and last character are different.
> 
> 
> >> Index: parse.c
> >> ===================================================================
> >> --- parse.c.orig	2007-05-31 04:57:13.000000000 -0700
> >> +++ parse.c	2007-05-31 05:02:09.000000000 -0700
> >> @@ -1076,7 +1076,7 @@
> >>  \f
> Maybe it's a problem of my mail reader, but I see a kind of special character here ?!?
> 
> 
> 
> 
> 

[-- Attachment #2: typos.diff --]
[-- Type: text/x-patch, Size: 5211 bytes --]

2007-05-31  Luis Machado  <luisgpm@br.ibm.com>

    * block.h: Fixed documentation typo.
    * dwarf2expr.h: Likewise.
    * frame-unwind.h: Likewise.
    * frame.c: Likewise.
    * parse.c: Likewise.
    * value.c: Likewise.
    * symtab.h: Likewise.

Index: block.h
===================================================================
--- block.h.orig	2007-05-31 05:17:47.000000000 -0700
+++ block.h	2007-05-31 05:58:06.000000000 -0700
@@ -105,7 +105,7 @@
      reading.  As of 16 Apr 93, this flag is never used to distinguish
      between gcc2 and the native compiler.
 
-     If there is no function corresponding to this block, this meaning
+     If there is no function corresponding to this block, the meaning
      of this flag is undefined.  */
 
   unsigned char gcc_compile_flag;
Index: dwarf2expr.h
===================================================================
--- dwarf2expr.h.orig	2007-05-31 05:17:47.000000000 -0700
+++ dwarf2expr.h	2007-05-31 05:58:06.000000000 -0700
@@ -46,7 +46,7 @@
   void (*read_mem) (void *baton, gdb_byte *buf, CORE_ADDR addr, size_t length);
 
   /* Return the location expression for the frame base attribute, in
-     START and LENGTH.  The result must be live until the current
+     START and LENGTH.  The result must live until the current
      expression evaluation is complete.  */
   void (*get_frame_base) (void *baton, gdb_byte **start, size_t *length);
 
@@ -59,7 +59,7 @@
 
   /* Return the location expression for the dwarf expression
      subroutine in the die at OFFSET in the current compilation unit.
-     The result must be live until the current expression evaluation
+     The result must live until the current expression evaluation
      is complete.  */
   unsigned char *(*get_subr) (void *baton, off_t offset, size_t *length);
 
Index: frame-unwind.h
===================================================================
--- frame-unwind.h.orig	2007-05-31 05:17:47.000000000 -0700
+++ frame-unwind.h	2007-05-31 06:00:02.000000000 -0700
@@ -33,8 +33,8 @@
 
 /* The following unwind functions assume a chain of frames forming the
    sequence: (outer) prev <-> this <-> next (inner).  All the
-   functions are called with called with the next frame's `struct
-   frame_info' and and this frame's prologue cache.
+   functions are called with the next frame's 'struct
+   frame_info' and this frame's prologue cache.
 
    THIS frame's register values can be obtained by unwinding NEXT
    frame's registers (a recursive operation).
Index: frame.c
===================================================================
--- frame.c.orig	2007-05-31 05:17:47.000000000 -0700
+++ frame.c	2007-05-31 05:58:06.000000000 -0700
@@ -1502,7 +1502,7 @@
 
   /* If THIS frame is not inner most (i.e., NEXT isn't the sentinel),
      and NEXT is `normal' (i.e., not a sigtramp, dummy, ....) THIS
-     frame's PC ends up pointing at the instruction fallowing the
+     frame's PC ends up pointing at the instruction following the
      "call".  Adjust that PC value so that it falls on the call
      instruction (which, hopefully, falls within THIS frame's code
      block).  So far it's proved to be a very good approximation.  See
Index: parse.c
===================================================================
--- parse.c.orig	2007-05-31 05:17:47.000000000 -0700
+++ parse.c	2007-05-31 05:58:06.000000000 -0700
@@ -1076,7 +1076,7 @@
 \f
 /* This page contains the two entry points to this file.  */
 
-/* Read an expression from the string *STRINGPTR points to,
+/* Read an expression from the string pointed to by *STRINGPTR,
    parse it, and return a pointer to a  struct expression  that we malloc.
    Use block BLOCK as the lexical context for variable names;
    if BLOCK is zero, use the block of the selected stack frame.
Index: symtab.h
===================================================================
--- symtab.h.orig	2007-05-31 05:17:47.000000000 -0700
+++ symtab.h	2007-05-31 05:58:06.000000000 -0700
@@ -640,7 +640,7 @@
   const struct symbol_ops *ops;
 
   /* Some symbols require additional information to be recorded on a
-     per- symbol basis.  Stash those values here. */
+     per-symbol basis.  Stash those values here. */
 
   union
   {
@@ -649,7 +649,7 @@
     /* An arbitrary data pointer.  Note that this data must be
        allocated using the same obstack as the symbol itself.  */
     /* So far it is only used by LOC_COMPUTED and LOC_COMPUTED_ARG to
-       find the location location information.  For a LOC_BLOCK symbol
+       find the location information.  For a LOC_BLOCK symbol
        for a function in a compilation unit compiled with DWARF 2
        information, this is information used internally by the DWARF 2
        code --- specifically, the location expression for the frame
Index: value.c
===================================================================
--- value.c.orig	2007-05-31 05:17:47.000000000 -0700
+++ value.c	2007-05-31 05:58:06.000000000 -0700
@@ -240,7 +240,7 @@
 }
 
 /* Allocate a  value  that has the correct length
-   for COUNT repetitions type TYPE.  */
+   for COUNT repetitions of type TYPE.  */
 
 struct value *
 allocate_repeat_value (struct type *type, int count)

Re: [patch] Fix assorted typos

[Daniel Jacobowitz]

On Thu, May 31, 2007 at 10:06:32AM -0300, Luis Machado wrote:
> 2007-05-31  Luis Machado  <luisgpm@br.ibm.com>
> 
>     * block.h: Fixed documentation typo.
>     * dwarf2expr.h: Likewise.
>     * frame-unwind.h: Likewise.
>     * frame.c: Likewise.
>     * parse.c: Likewise.
>     * value.c: Likewise.
>     * symtab.h: Likewise.

Thanks, these are OK.

-- 
Daniel Jacobowitz
CodeSourcery