From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8040 invoked by alias); 31 May 2007 13:06:45 -0000 Received: (qmail 7993 invoked by uid 22791); 31 May 2007 13:06:44 -0000 X-Spam-Check-By: sourceware.org Received: from igw2.br.ibm.com (HELO igw2.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 31 May 2007 13:06:41 +0000 Received: from mailhub1.br.ibm.com (mailhub1 [9.18.232.109]) by igw2.br.ibm.com (Postfix) with ESMTP id E5BE15BF64 for ; Thu, 31 May 2007 09:58:09 -0300 (BRT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l4VD6WLk892934 for ; Thu, 31 May 2007 10:06:33 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l4VD4TE5021377 for ; Thu, 31 May 2007 10:04:29 -0300 Received: from dyn531923.br.ibm.com (dyn531923.br.ibm.com [9.18.238.151] (may be forged)) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l4VD4Too021367; Thu, 31 May 2007 10:04:29 -0300 Subject: Re: [patch] Fix assorted typos From: Luis Machado Reply-To: luisgpm@linux.vnet.ibm.com To: Markus Deuling Cc: gdb-patches@sourceware.org In-Reply-To: <465EC1DA.3080206@de.ibm.com> References: <1180613386.8837.1.camel@localhost> <1180613976.8837.3.camel@localhost> <465EC1DA.3080206@de.ibm.com> Content-Type: multipart/mixed; boundary="=-ZSrhfkhO0f9O8NQ9bIly" Date: Thu, 31 May 2007 17:23:00 -0000 Message-Id: <1180616792.8837.7.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-05/txt/msg00437.txt.bz2 --=-ZSrhfkhO0f9O8NQ9bIly Content-Type: text/plain Content-Transfer-Encoding: 7bit Content-length: 1355 Markus, You are right. I've corrected the first and last character. As for the strange character, it's part of the context line from GDB's source. It's a ^L character. Best regards, Luis On Thu, 2007-05-31 at 14:38 +0200, Markus Deuling wrote: > Hi Luis, > I have two small comments. > > >> Index: frame-unwind.h > >> =================================================================== > >> --- frame-unwind.h.orig 2007-05-31 04:57:13.000000000 -0700 > >> +++ frame-unwind.h 2007-05-31 05:02:09.000000000 -0700 > >> @@ -33,8 +33,8 @@ > >> > >> /* The following unwind functions assume a chain of frames forming the > >> sequence: (outer) prev <-> this <-> next (inner). All the > >> - functions are called with called with the next frame's `struct > >> - frame_info' and and this frame's prologue cache. > >> + functions are called with the next frame's `struct > >> + frame_info' and this frame's prologue cache. > > `struct frame_info' The first and last character are different. > > > >> Index: parse.c > >> =================================================================== > >> --- parse.c.orig 2007-05-31 04:57:13.000000000 -0700 > >> +++ parse.c 2007-05-31 05:02:09.000000000 -0700 > >> @@ -1076,7 +1076,7 @@ > >> > Maybe it's a problem of my mail reader, but I see a kind of special character here ?!? > > > > > --=-ZSrhfkhO0f9O8NQ9bIly Content-Disposition: attachment; filename=typos.diff Content-Type: text/x-patch; name=typos.diff; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 5211 2007-05-31 Luis Machado * block.h: Fixed documentation typo. * dwarf2expr.h: Likewise. * frame-unwind.h: Likewise. * frame.c: Likewise. * parse.c: Likewise. * value.c: Likewise. * symtab.h: Likewise. Index: block.h =================================================================== --- block.h.orig 2007-05-31 05:17:47.000000000 -0700 +++ block.h 2007-05-31 05:58:06.000000000 -0700 @@ -105,7 +105,7 @@ reading. As of 16 Apr 93, this flag is never used to distinguish between gcc2 and the native compiler. - If there is no function corresponding to this block, this meaning + If there is no function corresponding to this block, the meaning of this flag is undefined. */ unsigned char gcc_compile_flag; Index: dwarf2expr.h =================================================================== --- dwarf2expr.h.orig 2007-05-31 05:17:47.000000000 -0700 +++ dwarf2expr.h 2007-05-31 05:58:06.000000000 -0700 @@ -46,7 +46,7 @@ void (*read_mem) (void *baton, gdb_byte *buf, CORE_ADDR addr, size_t length); /* Return the location expression for the frame base attribute, in - START and LENGTH. The result must be live until the current + START and LENGTH. The result must live until the current expression evaluation is complete. */ void (*get_frame_base) (void *baton, gdb_byte **start, size_t *length); @@ -59,7 +59,7 @@ /* Return the location expression for the dwarf expression subroutine in the die at OFFSET in the current compilation unit. - The result must be live until the current expression evaluation + The result must live until the current expression evaluation is complete. */ unsigned char *(*get_subr) (void *baton, off_t offset, size_t *length); Index: frame-unwind.h =================================================================== --- frame-unwind.h.orig 2007-05-31 05:17:47.000000000 -0700 +++ frame-unwind.h 2007-05-31 06:00:02.000000000 -0700 @@ -33,8 +33,8 @@ /* The following unwind functions assume a chain of frames forming the sequence: (outer) prev <-> this <-> next (inner). All the - functions are called with called with the next frame's `struct - frame_info' and and this frame's prologue cache. + functions are called with the next frame's 'struct + frame_info' and this frame's prologue cache. THIS frame's register values can be obtained by unwinding NEXT frame's registers (a recursive operation). Index: frame.c =================================================================== --- frame.c.orig 2007-05-31 05:17:47.000000000 -0700 +++ frame.c 2007-05-31 05:58:06.000000000 -0700 @@ -1502,7 +1502,7 @@ /* If THIS frame is not inner most (i.e., NEXT isn't the sentinel), and NEXT is `normal' (i.e., not a sigtramp, dummy, ....) THIS - frame's PC ends up pointing at the instruction fallowing the + frame's PC ends up pointing at the instruction following the "call". Adjust that PC value so that it falls on the call instruction (which, hopefully, falls within THIS frame's code block). So far it's proved to be a very good approximation. See Index: parse.c =================================================================== --- parse.c.orig 2007-05-31 05:17:47.000000000 -0700 +++ parse.c 2007-05-31 05:58:06.000000000 -0700 @@ -1076,7 +1076,7 @@ /* This page contains the two entry points to this file. */ -/* Read an expression from the string *STRINGPTR points to, +/* Read an expression from the string pointed to by *STRINGPTR, parse it, and return a pointer to a struct expression that we malloc. Use block BLOCK as the lexical context for variable names; if BLOCK is zero, use the block of the selected stack frame. Index: symtab.h =================================================================== --- symtab.h.orig 2007-05-31 05:17:47.000000000 -0700 +++ symtab.h 2007-05-31 05:58:06.000000000 -0700 @@ -640,7 +640,7 @@ const struct symbol_ops *ops; /* Some symbols require additional information to be recorded on a - per- symbol basis. Stash those values here. */ + per-symbol basis. Stash those values here. */ union { @@ -649,7 +649,7 @@ /* An arbitrary data pointer. Note that this data must be allocated using the same obstack as the symbol itself. */ /* So far it is only used by LOC_COMPUTED and LOC_COMPUTED_ARG to - find the location location information. For a LOC_BLOCK symbol + find the location information. For a LOC_BLOCK symbol for a function in a compilation unit compiled with DWARF 2 information, this is information used internally by the DWARF 2 code --- specifically, the location expression for the frame Index: value.c =================================================================== --- value.c.orig 2007-05-31 05:17:47.000000000 -0700 +++ value.c 2007-05-31 05:58:06.000000000 -0700 @@ -240,7 +240,7 @@ } /* Allocate a value that has the correct length - for COUNT repetitions type TYPE. */ + for COUNT repetitions of type TYPE. */ struct value * allocate_repeat_value (struct type *type, int count) --=-ZSrhfkhO0f9O8NQ9bIly--