Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado <luisgpm@linux.vnet.ibm.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch] Single stepping over atomic instruction sets for GDB 	6.6
Date: Mon, 30 Apr 2007 20:26:00 -0000	[thread overview]
Message-ID: <1177964357.15264.39.camel@localhost> (raw)
In-Reply-To: <20070429070740.GA16359@host0.dyn.jankratochvil.net>

Thanks Jan,

I think your patch could be applied on top of the first piece of the
single stepping patch, the one that actually changed code on infrun.c.
It's already in HEAD.

http://sourceware.org/ml/gdb-cvs/2007-04/msg00043.html

Regards,
Luis


On Sun, 2007-04-29 at 09:07 +0200, Jan Kratochvil wrote:
> On Sun, 29 Apr 2007 01:35:41 +0200, Luis Machado wrote:
> ...
> > I'd like to better understand your patch. So please, if you could go
> > through the modifications, that would be nice.
> 
> Your patch sets SINGLESTEP_BREAKPOINTS_INSERTED_P conditionally, according to
> whether SOFTWARE_SINGLE_STEP () was successful.
> SINGLESTEP_BREAKPOINTS_INSERTED_P was always set before so the original GDB
> code does not expect it can be unset.
> 
> I have updated the code to handle the case when SOFTWARE_SINGLE_STEP () failed
> (and so SINGLESTEP_BREAKPOINTS_INSERTED_P is unset; it could safely fail to
> software singlestep because hardware singlestepping feature is available).
> 
> 
> Regards,
> Jan


      reply	other threads:[~2007-04-30 20:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-23 21:06 Luis Machado
2007-04-28 18:16 ` Jan Kratochvil
2007-04-28 23:37   ` Luis Machado
2007-04-29 15:50     ` Jan Kratochvil
2007-04-30 20:26       ` Luis Machado [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1177964357.15264.39.camel@localhost \
    --to=luisgpm@linux.vnet.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=jan.kratochvil@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox