From: Jan Kratochvil <jan.kratochvil@redhat.com>
To: Luis Machado <luisgpm@linux.vnet.ibm.com>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [patch] Single stepping over atomic instruction sets for GDB 6.6
Date: Sun, 29 Apr 2007 15:50:00 -0000 [thread overview]
Message-ID: <20070429070740.GA16359@host0.dyn.jankratochvil.net> (raw)
In-Reply-To: <1177803342.6280.54.camel@localhost>
On Sun, 29 Apr 2007 01:35:41 +0200, Luis Machado wrote:
...
> I'd like to better understand your patch. So please, if you could go
> through the modifications, that would be nice.
Your patch sets SINGLESTEP_BREAKPOINTS_INSERTED_P conditionally, according to
whether SOFTWARE_SINGLE_STEP () was successful.
SINGLESTEP_BREAKPOINTS_INSERTED_P was always set before so the original GDB
code does not expect it can be unset.
I have updated the code to handle the case when SOFTWARE_SINGLE_STEP () failed
(and so SINGLESTEP_BREAKPOINTS_INSERTED_P is unset; it could safely fail to
software singlestep because hardware singlestepping feature is available).
Regards,
Jan
next prev parent reply other threads:[~2007-04-29 7:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 21:06 Luis Machado
2007-04-28 18:16 ` Jan Kratochvil
2007-04-28 23:37 ` Luis Machado
2007-04-29 15:50 ` Jan Kratochvil [this message]
2007-04-30 20:26 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070429070740.GA16359@host0.dyn.jankratochvil.net \
--to=jan.kratochvil@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox