From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19540 invoked by alias); 30 Apr 2007 20:19:42 -0000 Received: (qmail 19525 invoked by uid 22791); 30 Apr 2007 20:19:41 -0000 X-Spam-Check-By: sourceware.org Received: from igw3.br.ibm.com (HELO igw3.br.ibm.com) (32.104.18.26) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 30 Apr 2007 21:19:38 +0100 Received: from mailhub1.br.ibm.com (unknown [9.18.232.109]) by igw3.br.ibm.com (Postfix) with ESMTP id AAE0C39001C for ; Mon, 30 Apr 2007 17:11:45 -0300 (BRT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.18.232.46]) by mailhub1.br.ibm.com (8.13.8/8.13.8/NCO v8.3) with ESMTP id l3UKJK1Z1401002 for ; Mon, 30 Apr 2007 17:19:20 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id l3UKHJAV015270 for ; Mon, 30 Apr 2007 17:17:19 -0300 Received: from [9.18.238.71] ([9.18.238.71]) by d24av01.br.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id l3UKHHxM015226; Mon, 30 Apr 2007 17:17:19 -0300 Subject: Re: [patch] Single stepping over atomic instruction sets for GDB 6.6 From: Luis Machado Reply-To: luisgpm@linux.vnet.ibm.com To: Jan Kratochvil Cc: gdb-patches ml In-Reply-To: <20070429070740.GA16359@host0.dyn.jankratochvil.net> References: <1177352371.15414.29.camel@localhost> <20070428175641.GA2136@host0.dyn.jankratochvil.net> <1177803342.6280.54.camel@localhost> <20070429070740.GA16359@host0.dyn.jankratochvil.net> Content-Type: text/plain Date: Mon, 30 Apr 2007 20:26:00 -0000 Message-Id: <1177964357.15264.39.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.6.1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2007-04/txt/msg00423.txt.bz2 Thanks Jan, I think your patch could be applied on top of the first piece of the single stepping patch, the one that actually changed code on infrun.c. It's already in HEAD. http://sourceware.org/ml/gdb-cvs/2007-04/msg00043.html Regards, Luis On Sun, 2007-04-29 at 09:07 +0200, Jan Kratochvil wrote: > On Sun, 29 Apr 2007 01:35:41 +0200, Luis Machado wrote: > ... > > I'd like to better understand your patch. So please, if you could go > > through the modifications, that would be nice. > > Your patch sets SINGLESTEP_BREAKPOINTS_INSERTED_P conditionally, according to > whether SOFTWARE_SINGLE_STEP () was successful. > SINGLESTEP_BREAKPOINTS_INSERTED_P was always set before so the original GDB > code does not expect it can be unset. > > I have updated the code to handle the case when SOFTWARE_SINGLE_STEP () failed > (and so SINGLESTEP_BREAKPOINTS_INSERTED_P is unset; it could safely fail to > software singlestep because hardware singlestepping feature is available). > > > Regards, > Jan