From: Michael Snyder <Michael.Snyder@access-company.com>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: Daniel Jacobowitz <drow@false.org>,
gdb-patches@sourceware.org,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: mips-tdep.c: Style fixes
Date: Tue, 17 Apr 2007 20:45:00 -0000 [thread overview]
Message-ID: <1176842360.5381.19.camel@svmsnyderlnx.palmsource.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0704171906380.17222@perivale.mips.com>
On Tue, 2007-04-17 at 19:12 +0100, Maciej W. Rozycki wrote:
> On Tue, 17 Apr 2007, Daniel Jacobowitz wrote:
>
> > > - int partial_len = (len < mips_abi_regsize (gdbarch)
> > > - ? len : mips_abi_regsize (gdbarch));
> > > + int partial_len = (len < mips_abi_regsize (gdbarch))
> > > + ? len : mips_abi_regsize (gdbarch);
> >
> > These (and most of the others) were actually there for a reason.
> > Emacs will move that second line leftwards if there isn't an outer
> > layer of parentheses; I believe GNU Indent and gdb_indent.sh will also.
>
> I can revert these, no problem -- it just looks strange and is not useful
> from the language's point of view to have the right-hand side of an
> assignment in brackets.
Both statements contain redundant parens.
> OTOH, this qualifies as a workaround for what should probably be considered
> a bug in the respective tools, so perhaps those should be fixed instead?
Probably, but we don't maintain those - we maintain gdb.
prev parent reply other threads:[~2007-04-17 20:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-17 18:03 Maciej W. Rozycki
2007-04-17 18:13 ` Daniel Jacobowitz
2007-04-17 18:57 ` Maciej W. Rozycki
2007-04-17 19:18 ` Andreas Schwab
2007-04-17 20:39 ` Daniel Jacobowitz
2007-04-18 8:31 ` Maciej W. Rozycki
2007-04-17 20:45 ` Michael Snyder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1176842360.5381.19.camel@svmsnyderlnx.palmsource.com \
--to=michael.snyder@access-company.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=macro@linux-mips.org \
--cc=macro@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox