Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Maciej W. Rozycki" <macro@mips.com>
To: gdb-patches@sourceware.org
Cc: "Maciej W. Rozycki" <macro@linux-mips.org>
Subject: mips-tdep.c: Style fixes
Date: Tue, 17 Apr 2007 18:03:00 -0000	[thread overview]
Message-ID: <Pine.LNX.4.61.0704171728440.17222@perivale.mips.com> (raw)

Hello,

 Applied as obvious:

2007-04-17  Maciej W. Rozycki  <macro@mips.com>

	* mips-tdep.c (mips_eabi_push_dummy_call): Rearrange some
	brackets.
	(mips_n32n64_push_dummy_call): Likewise.  Reformat some 
	expressions.
	(mips_o32_push_dummy_call): Likewise.
	(mips_o64_push_dummy_call): Likewise.

  Maciej

Index: gdb/mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.412
diff -u -p -r1.412 mips-tdep.c
--- gdb/mips-tdep.c	17 Apr 2007 16:25:49 -0000	1.412
+++ gdb/mips-tdep.c	17 Apr 2007 16:26:24 -0000
@@ -2558,8 +2558,8 @@ mips_eabi_push_dummy_call (struct gdbarc
 	    {
 	      /* Remember if the argument was written to the stack.  */
 	      int stack_used_p = 0;
-	      int partial_len = (len < mips_abi_regsize (gdbarch)
-				 ? len : mips_abi_regsize (gdbarch));
+	      int partial_len = (len < mips_abi_regsize (gdbarch))
+				? len : mips_abi_regsize (gdbarch);
 
 	      if (mips_debug)
 		fprintf_unfiltered (gdb_stdlog, " -- partial=%d",
@@ -2785,8 +2785,8 @@ mips_n32n64_push_dummy_call (struct gdba
 	    {
 	      /* Remember if the argument was written to the stack.  */
 	      int stack_used_p = 0;
-	      int partial_len = (len < mips_abi_regsize (gdbarch)
-				 ? len : mips_abi_regsize (gdbarch));
+	      int partial_len = (len < mips_abi_regsize (gdbarch))
+				? len : mips_abi_regsize (gdbarch);
 
 	      if (mips_debug)
 		fprintf_unfiltered (gdb_stdlog, " -- partial=%d",
@@ -2871,10 +2871,10 @@ mips_n32n64_push_dummy_call (struct gdba
 
 		  if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG
 		      && partial_len < mips_abi_regsize (gdbarch)
-		      && (typecode == TYPE_CODE_STRUCT ||
-			  typecode == TYPE_CODE_UNION))
-		    regval <<= ((mips_abi_regsize (gdbarch) - partial_len) *
-				TARGET_CHAR_BIT);
+		      && (typecode == TYPE_CODE_STRUCT
+			  || typecode == TYPE_CODE_UNION))
+		    regval <<= (mips_abi_regsize (gdbarch) - partial_len)
+			       * TARGET_CHAR_BIT;
 
 		  if (mips_debug)
 		    fprintf_filtered (gdb_stdlog, " - reg=%d val=%s",
@@ -3219,8 +3219,8 @@ mips_o32_push_dummy_call (struct gdbarch
 	    {
 	      /* Remember if the argument was written to the stack.  */
 	      int stack_used_p = 0;
-	      int partial_len = (len < mips_abi_regsize (gdbarch)
-				 ? len : mips_abi_regsize (gdbarch));
+	      int partial_len = (len < mips_abi_regsize (gdbarch))
+				? len : mips_abi_regsize (gdbarch);
 
 	      if (mips_debug)
 		fprintf_unfiltered (gdb_stdlog, " -- partial=%d",
@@ -3306,10 +3306,10 @@ mips_o32_push_dummy_call (struct gdbarch
 		  if (mips_abi_regsize (gdbarch) < 8
 		      && TARGET_BYTE_ORDER == BFD_ENDIAN_BIG
 		      && partial_len < mips_abi_regsize (gdbarch)
-		      && (typecode == TYPE_CODE_STRUCT ||
-			  typecode == TYPE_CODE_UNION))
-		    regval <<= ((mips_abi_regsize (gdbarch) - partial_len) *
-				TARGET_CHAR_BIT);
+		      && (typecode == TYPE_CODE_STRUCT
+			  || typecode == TYPE_CODE_UNION))
+		    regval <<= (mips_abi_regsize (gdbarch) - partial_len)
+			       * TARGET_CHAR_BIT;
 
 		  if (mips_debug)
 		    fprintf_filtered (gdb_stdlog, " - reg=%d val=%s",
@@ -3680,8 +3680,8 @@ mips_o64_push_dummy_call (struct gdbarch
 	    {
 	      /* Remember if the argument was written to the stack.  */
 	      int stack_used_p = 0;
-	      int partial_len = (len < mips_abi_regsize (gdbarch)
-				 ? len : mips_abi_regsize (gdbarch));
+	      int partial_len = (len < mips_abi_regsize (gdbarch))
+				? len : mips_abi_regsize (gdbarch);
 
 	      if (mips_debug)
 		fprintf_unfiltered (gdb_stdlog, " -- partial=%d",
@@ -3750,10 +3750,10 @@ mips_o64_push_dummy_call (struct gdbarch
 
 		  if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG
 		      && partial_len < mips_abi_regsize (gdbarch)
-		      && (typecode == TYPE_CODE_STRUCT ||
-			  typecode == TYPE_CODE_UNION))
-		    regval <<= ((mips_abi_regsize (gdbarch) - partial_len) *
-				TARGET_CHAR_BIT);
+		      && (typecode == TYPE_CODE_STRUCT
+			  || typecode == TYPE_CODE_UNION))
+		    regval <<= (mips_abi_regsize (gdbarch) - partial_len)
+			       * TARGET_CHAR_BIT;
 
 		  if (mips_debug)
 		    fprintf_filtered (gdb_stdlog, " - reg=%d val=%s",


             reply	other threads:[~2007-04-17 17:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-17 18:03 Maciej W. Rozycki [this message]
2007-04-17 18:13 ` Daniel Jacobowitz
2007-04-17 18:57   ` Maciej W. Rozycki
2007-04-17 19:18     ` Andreas Schwab
2007-04-17 20:39     ` Daniel Jacobowitz
2007-04-18  8:31       ` Maciej W. Rozycki
2007-04-17 20:45     ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.61.0704171728440.17222@perivale.mips.com \
    --to=macro@mips.com \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox