From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-48521-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 17236 invoked by alias); 17 Apr 2007 20:39:31 -0000
Received: (qmail 17224 invoked by uid 22791); 17 Apr 2007 20:39:30 -0000
X-Spam-Check-By: sourceware.org
Received: from mx1.palmsource.com (HELO mx1.palmsource.com) (12.7.175.13)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 17 Apr 2007 21:39:25 +0100
Received: from localhost (localhost [127.0.0.1]) 	by localhost.domain.tld (Postfix) with ESMTP 	id 73B355EF75; Tue, 17 Apr 2007 13:39:23 -0700 (PDT)
Received: from mx1.palmsource.com ([127.0.0.1])  by localhost (mx1.palmsource.com [127.0.0.1]) (amavisd-new, port 10024)  with LMTP id 21201-08-2; Tue, 17 Apr 2007 13:39:20 -0700 (PDT)
Received: from ussunex03.svl.access-company.com (ussunm001.palmsource.com [192.168.101.12]) 	by mx1.palmsource.com (Postfix) with ESMTP 	id 8DCB95EE84; Tue, 17 Apr 2007 13:39:20 -0700 (PDT)
Received: from 192.168.92.56 ([192.168.92.56]) by ussunex03.svl.access-company.com ([192.168.101.12]) via Exchange Front-End Server owa.access-company.com ([10.0.20.19]) with Microsoft Exchange Server HTTP-DAV ;  Tue, 17 Apr 2007 20:40:54 +0000
Received: from svmsnyderlnx by owa.access-company.com; 17 Apr 2007 13:39:20 -0700
Subject: Re: mips-tdep.c: Style fixes
From: Michael Snyder <Michael.Snyder@access-company.com>
To: "Maciej W. Rozycki" <macro@mips.com>
Cc: Daniel Jacobowitz <drow@false.org>, gdb-patches@sourceware.org, 	"Maciej W. Rozycki" <macro@linux-mips.org>
In-Reply-To: <Pine.LNX.4.61.0704171906380.17222@perivale.mips.com>
References: <Pine.LNX.4.61.0704171728440.17222@perivale.mips.com> 	 <20070417180313.GA9378@caradoc.them.org> 	 <Pine.LNX.4.61.0704171906380.17222@perivale.mips.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Date: Tue, 17 Apr 2007 20:45:00 -0000
Message-Id: <1176842360.5381.19.camel@svmsnyderlnx.palmsource.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.8.1
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2007-04/txt/msg00269.txt.bz2

On Tue, 2007-04-17 at 19:12 +0100, Maciej W. Rozycki wrote:
> On Tue, 17 Apr 2007, Daniel Jacobowitz wrote:
> 
> > > -	      int partial_len = (len < mips_abi_regsize (gdbarch)
> > > -				 ? len : mips_abi_regsize (gdbarch));
> > > +	      int partial_len = (len < mips_abi_regsize (gdbarch))
> > > +				? len : mips_abi_regsize (gdbarch);
> > 
> > These (and most of the others) were actually there for a reason.
> > Emacs will move that second line leftwards if there isn't an outer
> > layer of parentheses; I believe GNU Indent and gdb_indent.sh will also.
> 
>  I can revert these, no problem -- it just looks strange and is not useful 
> from the language's point of view to have the right-hand side of an 
> assignment in brackets. 

Both statements contain redundant parens.

>  OTOH, this qualifies as a workaround for what should probably be considered
>  a bug in the respective tools, so perhaps those should be fixed instead?

Probably, but we don't maintain those - we maintain gdb.