testsuite gdb.base/constvars: force allocation of local variables

testsuite gdb.base/constvars: force allocation of local variables

[Christophe LYON]

Hello,

I propose the following patch in order to force allocation of variables 
'crass' and 'crisp'.

Christophe.


2006-11-08 Christophe Lyon <christophe.lyon@st.com>

	* gdb.base/constvars.c (main): Write to crass and crips, so that
           they are allocated by the compiler.

Index: gdb.base/constvars.c
===================================================================
--- gdb.base/constvars.c        (revision 96)
+++ gdb.base/constvars.c        (working copy)
@@ -169,8 +169,8 @@ main (void)

    /* various structs with const members */

-  struct crass { char * const ptr; } crass;
-  struct crisp { char * const *ptr; } crisp;
+  struct crass { char * const ptr; } crass = { lamprey} ;
+  struct crisp { char * const *ptr; } crisp = { &lamprey} ;

    /* misc. references */
    /*

Re: testsuite gdb.base/constvars: force allocation of local variables

[Daniel Jacobowitz]

On Wed, Nov 08, 2006 at 02:51:48PM +0100, Christophe LYON wrote:
> Hello,
> 
> I propose the following patch in order to force allocation of variables 
> 'crass' and 'crisp'.

What compiler does this affect?

-- 
Daniel Jacobowitz
CodeSourcery

Re: testsuite gdb.base/constvars: force allocation of local variables

[Daniel Jacobowitz]

Please, reply to the list next time.  This patch is OK if you fix your
formatting.

On Wed, Nov 08, 2006 at 02:51:48PM +0100, Christophe LYON wrote:
> 
> 2006-11-08 Christophe Lyon <christophe.lyon@st.com>
> 
> 	* gdb.base/constvars.c (main): Write to crass and crips, so that
>           they are allocated by the compiler.

Tab on the second line there.

> -  struct crass { char * const ptr; } crass;
> -  struct crisp { char * const *ptr; } crisp;
> +  struct crass { char * const ptr; } crass = { lamprey} ;
> +  struct crisp { char * const *ptr; } crisp = { &lamprey} ;

Space before "}" and not after.

-- 
Daniel Jacobowitz
CodeSourcery

Re: testsuite gdb.base/constvars: force allocation of local variables

[Christophe LYON]

Daniel Jacobowitz wrote:
> On Wed, Nov 08, 2006 at 02:51:48PM +0100, Christophe LYON wrote:
>> Hello,
>>
>> I propose the following patch in order to force allocation of variables 
>> 'crass' and 'crisp'.
> 
> What compiler does this affect?
> 

The compiler we develop is a retargetting of Open64.


Christophe.

Re: testsuite gdb.base/constvars: force allocation of local variables

[Christophe LYON]

Daniel Jacobowitz wrote:
> Please, reply to the list next time.  This patch is OK if you fix your
> formatting.
> 

OK, so here is the revised version:


2006-11-08 Christophe Lyon <christophe.lyon@st.com>

	* gdb.base/constvars.c (main): Write to crass and crips, so that
	they are allocated by the compiler.

Index: gdb.base/constvars.c
===================================================================
--- gdb.base/constvars.c        (revision 96)
+++ gdb.base/constvars.c        (working copy)
@@ -169,8 +169,8 @@ main (void)

    /* various structs with const members */

-  struct crass { char * const ptr; } crass;
-  struct crisp { char * const *ptr; } crisp;
+  struct crass { char * const ptr; } crass = { lamprey };
+  struct crisp { char * const *ptr; } crisp = { &lamprey };

    /* misc. references */
    /*


--
Christophe.

Re: testsuite gdb.base/constvars: force allocation of local variables

[Daniel Jacobowitz]

On Wed, Nov 08, 2006 at 05:43:41PM +0100, Christophe LYON wrote:
> Daniel Jacobowitz wrote:
> >Please, reply to the list next time.  This patch is OK if you fix your
> >formatting.
> >
> 
> OK, so here is the revised version:

OK, and thanks.

-- 
Daniel Jacobowitz
CodeSourcery

Re: testsuite gdb.base/constvars: force allocation of local variables

[Frederic RISS]

On Wed, 2006-11-08 at 11:52 -0500, Daniel Jacobowitz wrote:
> On Wed, Nov 08, 2006 at 05:43:41PM +0100, Christophe LYON wrote:
> > Daniel Jacobowitz wrote:
> > >Please, reply to the list next time.  This patch is OK if you fix your
> > >formatting.
> > >
> > 
> > OK, so here is the revised version:
> 
> OK, and thanks.

I checked this in for Christophe with a minor ChangeLog formating fix (2
spaces around the name).