From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17507 invoked by alias); 8 Nov 2006 16:15:15 -0000 Received: (qmail 17487 invoked by uid 22791); 8 Nov 2006 16:15:14 -0000 X-Spam-Check-By: sourceware.org Received: from nevyn.them.org (HELO nevyn.them.org) (66.93.172.17) by sourceware.org (qpsmtpd/0.31.1) with ESMTP; Wed, 08 Nov 2006 16:15:04 +0000 Received: from drow by nevyn.them.org with local (Exim 4.54) id 1Ghq4s-0007ds-ME for gdb-patches@sourceware.org; Wed, 08 Nov 2006 11:15:02 -0500 Date: Wed, 08 Nov 2006 16:15:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sourceware.org Subject: Re: testsuite gdb.base/constvars: force allocation of local variables Message-ID: <20061108161502.GA29286@nevyn.them.org> Mail-Followup-To: gdb-patches@sourceware.org References: <4551E0F4.7030803@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4551E0F4.7030803@st.com> User-Agent: Mutt/1.5.13 (2006-08-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-11/txt/msg00041.txt.bz2 Please, reply to the list next time. This patch is OK if you fix your formatting. On Wed, Nov 08, 2006 at 02:51:48PM +0100, Christophe LYON wrote: > > 2006-11-08 Christophe Lyon > > * gdb.base/constvars.c (main): Write to crass and crips, so that > they are allocated by the compiler. Tab on the second line there. > - struct crass { char * const ptr; } crass; > - struct crisp { char * const *ptr; } crisp; > + struct crass { char * const ptr; } crass = { lamprey} ; > + struct crisp { char * const *ptr; } crisp = { &lamprey} ; Space before "}" and not after. -- Daniel Jacobowitz CodeSourcery