From: PAUL GILLIAM <pgilliam@us.ibm.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: drow@false.org, gdb-patches@sources.redhat.com
Subject: Re: [patch] Can't build ppc32 GDB
Date: Fri, 05 May 2006 20:47:00 -0000 [thread overview]
Message-ID: <1146862113.16180.29.camel@dufur.beaverton.ibm.com> (raw)
In-Reply-To: <200605052029.k45KT7T4017379@elgar.sibelius.xs4all.nl>
On Fri, 2006-05-05 at 22:29 +0200, Mark Kettenis wrote:
> Could you do me a favour, and replace:
>
> *(long *) & buf[bytes_transferred]
>
> with
>
> *(long *) &buf[bytes_transferred]
>
> ?
>
> That extra space has been there ever since the code was reindented
> using indent(1), but really shouldn't be there. It makes me think
> it's a bitwise and instead of address off operator.
>
> Otherwise, yes, ok with that change.
>
> Mark
OK, committed. There was another case of *(long *) & buf.... and I
fixed that too.
I also fixed an entry in the ChangeLog that had leading spaces instead
of a tab.
-=# Paul #=-
prev parent reply other threads:[~2006-05-05 20:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-25 0:18 PAUL GILLIAM
2006-04-25 0:22 ` PAUL GILLIAM
2006-04-25 19:38 ` Mark Kettenis
2006-05-03 23:32 ` PAUL GILLIAM
2006-05-04 7:12 ` Mark Kettenis
2006-05-05 16:30 ` Daniel Jacobowitz
2006-05-05 16:50 ` Mark Kettenis
2006-05-05 18:31 ` PAUL GILLIAM
2006-05-05 19:55 ` Mark Kettenis
2006-05-05 20:18 ` PAUL GILLIAM
2006-05-05 20:21 ` PAUL GILLIAM
2006-05-05 20:29 ` Mark Kettenis
2006-05-05 20:47 ` PAUL GILLIAM [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146862113.16180.29.camel@dufur.beaverton.ibm.com \
--to=pgilliam@us.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox