From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7392 invoked by alias); 5 May 2006 20:47:25 -0000 Received: (qmail 7380 invoked by uid 22791); 5 May 2006 20:47:24 -0000 X-Spam-Check-By: sourceware.org Received: from e34.co.us.ibm.com (HELO e34.co.us.ibm.com) (32.97.110.152) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 May 2006 20:47:19 +0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e34.co.us.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k45KlHiv011391 for ; Fri, 5 May 2006 16:47:17 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.12.10/NCO/VER6.8) with ESMTP id k45KlBN9178772 for ; Fri, 5 May 2006 14:47:16 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id k45KlB7M001073 for ; Fri, 5 May 2006 14:47:11 -0600 Received: from dufur.beaverton.ibm.com (dufur.beaverton.ibm.com [9.47.22.20]) by d03av02.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id k45KlBcl001042; Fri, 5 May 2006 14:47:11 -0600 Subject: Re: [patch] Can't build ppc32 GDB From: PAUL GILLIAM Reply-To: pgilliam@us.ibm.com To: Mark Kettenis Cc: drow@false.org, gdb-patches@sources.redhat.com In-Reply-To: <200605052029.k45KT7T4017379@elgar.sibelius.xs4all.nl> References: <1145924338.18934.45.camel@dufur.beaverton.ibm.com> <1145924593.18934.48.camel@dufur.beaverton.ibm.com> <200604251938.k3PJc9dl014571@elgar.sibelius.xs4all.nl> <1146699224.16180.4.camel@dufur.beaverton.ibm.com> <25493.192.87.1.22.1146726734.squirrel@webmail.xs4all.nl> <20060505162955.GB31029@nevyn.them.org> <200605051649.k45GnKob023219@elgar.sibelius.xs4all.nl> <1146853938.16180.11.camel@dufur.beaverton.ibm.com> <200605051954.k45JsOhL021761@elgar.sibelius.xs4all.nl> <1146860412.16180.21.camel@dufur.beaverton.ibm.com> <200605052029.k45KT7T4017379@elgar.sibelius.xs4all.nl> Content-Type: text/plain Date: Fri, 05 May 2006 20:47:00 -0000 Message-Id: <1146862113.16180.29.camel@dufur.beaverton.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.2 (2.2.2-5) Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00105.txt.bz2 On Fri, 2006-05-05 at 22:29 +0200, Mark Kettenis wrote: > Could you do me a favour, and replace: > > *(long *) & buf[bytes_transferred] > > with > > *(long *) &buf[bytes_transferred] > > ? > > That extra space has been there ever since the code was reindented > using indent(1), but really shouldn't be there. It makes me think > it's a bitwise and instead of address off operator. > > Otherwise, yes, ok with that change. > > Mark OK, committed. There was another case of *(long *) & buf.... and I fixed that too. I also fixed an entry in the ChangeLog that had leading spaces instead of a tab. -=# Paul #=-