From: PAUL GILLIAM <pgilliam@us.ibm.com>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: drow@false.org, gdb-patches@sources.redhat.com
Subject: Re: [patch] Can't build ppc32 GDB
Date: Fri, 05 May 2006 20:18:00 -0000 [thread overview]
Message-ID: <1146860412.16180.21.camel@dufur.beaverton.ibm.com> (raw)
In-Reply-To: <200605051954.k45JsOhL021761@elgar.sibelius.xs4all.nl>
On Fri, 2006-05-05 at 21:54 +0200, Mark Kettenis wrote:
> > From: PAUL GILLIAM <pgilliam@us.ibm.com>
> > Date: Fri, 05 May 2006 11:32:18 -0700
> >
> > OK, How about this? I tried to make everyone happy :-)
> >
> > Here is an excerpt:
> >
> > #ifdef HAVE_STDINT_H
> > #include <stdint.h>
> > #define CORE_ADDR_CAST (uintptr_t)
> > #else
> > #define CORE_ADDR_CAST (CORE_ADDR)(unsigned long)
> > #endif
> > . . .
> > last_stopped_data_address = CORE_ADDR_CAST siginfo.si_addr;
> >
> > Then when there is a gdb_stdint.h, I'll submit another patch to include
> > it and replace CORE_ADDR_CAST with just (uintptr_t).
> >
> > Ok to commit?
>
> Sorry Paul, this is silly. Just include <stdint.h> and use uintptr_t
> unconditionally. Or use unsigned long (the extra CORE_ADDR cast isn't
> necessary) if you're really scared that someone will try to compile
> GDB on a system with glibc 2.0.x.
Alright, I admit it is a little silly. I thought it would fit right in
with a lot of what I see on this mailing list :-)
Anyway, I changed it as you suggested: OK to commit?
-=# Paul #=-
next prev parent reply other threads:[~2006-05-05 20:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-25 0:18 PAUL GILLIAM
2006-04-25 0:22 ` PAUL GILLIAM
2006-04-25 19:38 ` Mark Kettenis
2006-05-03 23:32 ` PAUL GILLIAM
2006-05-04 7:12 ` Mark Kettenis
2006-05-05 16:30 ` Daniel Jacobowitz
2006-05-05 16:50 ` Mark Kettenis
2006-05-05 18:31 ` PAUL GILLIAM
2006-05-05 19:55 ` Mark Kettenis
2006-05-05 20:18 ` PAUL GILLIAM [this message]
2006-05-05 20:21 ` PAUL GILLIAM
2006-05-05 20:29 ` Mark Kettenis
2006-05-05 20:47 ` PAUL GILLIAM
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146860412.16180.21.camel@dufur.beaverton.ibm.com \
--to=pgilliam@us.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox