From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31057 invoked by alias); 5 May 2006 20:18:56 -0000 Received: (qmail 31049 invoked by uid 22791); 5 May 2006 20:18:56 -0000 X-Spam-Check-By: sourceware.org Received: from e31.co.us.ibm.com (HELO e31.co.us.ibm.com) (32.97.110.149) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 05 May 2006 20:18:52 +0000 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e31.co.us.ibm.com (8.12.11.20060308/8.12.11) with ESMTP id k45KIpef030905 for ; Fri, 5 May 2006 16:18:51 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.12.10/NCO/VER6.8) with ESMTP id k45KIoN9182342 for ; Fri, 5 May 2006 14:18:50 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11/8.13.3) with ESMTP id k45KIoVg009486 for ; Fri, 5 May 2006 14:18:50 -0600 Received: from dufur.beaverton.ibm.com (dufur.beaverton.ibm.com [9.47.22.20]) by d03av02.boulder.ibm.com (8.12.11/8.12.11) with ESMTP id k45KIn3W009449; Fri, 5 May 2006 14:18:49 -0600 Subject: Re: [patch] Can't build ppc32 GDB From: PAUL GILLIAM Reply-To: pgilliam@us.ibm.com To: Mark Kettenis Cc: drow@false.org, gdb-patches@sources.redhat.com In-Reply-To: <200605051954.k45JsOhL021761@elgar.sibelius.xs4all.nl> References: <1145924338.18934.45.camel@dufur.beaverton.ibm.com> <1145924593.18934.48.camel@dufur.beaverton.ibm.com> <200604251938.k3PJc9dl014571@elgar.sibelius.xs4all.nl> <1146699224.16180.4.camel@dufur.beaverton.ibm.com> <25493.192.87.1.22.1146726734.squirrel@webmail.xs4all.nl> <20060505162955.GB31029@nevyn.them.org> <200605051649.k45GnKob023219@elgar.sibelius.xs4all.nl> <1146853938.16180.11.camel@dufur.beaverton.ibm.com> <200605051954.k45JsOhL021761@elgar.sibelius.xs4all.nl> Content-Type: text/plain Date: Fri, 05 May 2006 20:18:00 -0000 Message-Id: <1146860412.16180.21.camel@dufur.beaverton.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.2 (2.2.2-5) Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2006-05/txt/msg00098.txt.bz2 On Fri, 2006-05-05 at 21:54 +0200, Mark Kettenis wrote: > > From: PAUL GILLIAM > > Date: Fri, 05 May 2006 11:32:18 -0700 > > > > OK, How about this? I tried to make everyone happy :-) > > > > Here is an excerpt: > > > > #ifdef HAVE_STDINT_H > > #include > > #define CORE_ADDR_CAST (uintptr_t) > > #else > > #define CORE_ADDR_CAST (CORE_ADDR)(unsigned long) > > #endif > > . . . > > last_stopped_data_address = CORE_ADDR_CAST siginfo.si_addr; > > > > Then when there is a gdb_stdint.h, I'll submit another patch to include > > it and replace CORE_ADDR_CAST with just (uintptr_t). > > > > Ok to commit? > > Sorry Paul, this is silly. Just include and use uintptr_t > unconditionally. Or use unsigned long (the extra CORE_ADDR cast isn't > necessary) if you're really scared that someone will try to compile > GDB on a system with glibc 2.0.x. Alright, I admit it is a little silly. I thought it would fit right in with a lot of what I see on this mailing list :-) Anyway, I changed it as you suggested: OK to commit? -=# Paul #=-