Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Wu Zhou <woodzltc@cn.ibm.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: pgilliam@us.ibm.com, gdb-patches@sources.redhat.com
Subject: Re: [patch] update gdb.base/shreloc.exp to use new shared library infrastructure
Date: Tue, 17 May 2005 15:15:00 -0000	[thread overview]
Message-ID: <1116340726.428a01f64cf3b@imap.linux.ibm.com> (raw)

Quoting Daniel Jacobowitz <drow@false.org>:

> On Tue, May 17, 2005 at 06:20:02AM -0400, Wu Zhou wrote:
> > Hi Daniel, 
> > 
> > Thanks for pointing out these errors for me.  Followed is the re-worked 
> > patch. 
> > 
> > 2005-05-17  Paul Gilliam  <pgilliam@us.ibm.com>
> >             Wu Zhou <woodzltc@cn.ibm.com>
> > 
> >        * gdb.base/shreloc.exp: Use gdb_compile_shlib.  Add support for 
> >        IBM's xlc compiler. 
> >        * gdb.base/shreloc1.c (fn_1): Reference variable static_var_1.
> >        * gdb.base/shreloc2.c (fn_2): Reference variable static_var_2.
> 
> This is fine to commit; do you have write access?
> 
> Make sure to use tabs at the beginning of lines in the ChangeLog, and
> to put two spaces between your name and email address.

No. I don't have write access yet.  As you might know, I am very new to
GDB development.  Maybe I need some good patches to get the write access.
So maybe someone else need to commit this(I can rewrite the changelog). 
I could ask Paul to do this.  But if you are willing to do it, that will 
be highly appreciated. 

BTW.  thanks for reminding me of the wording rules. And also for your kind
helps all the way.  I learned a lot from working with you on this first 
patch, which is also my first experience for contributing code to GNU 
projects.  With your and others' kind help, I believe I can do much better
next time.  Thanks once again. 

===============The re-worked changelog=================================
2005-05-17  Paul Gilliam  <pgilliam@us.ibm.com>
            Wu Zhou  <woodzltc@cn.ibm.com>

	* gdb.base/shreloc.exp: Use gdb_compile_shlib.  Add support for 
	IBM's xlc compiler. 
	* gdb.base/shreloc1.c (fn_1): Reference variable static_var_1.
	* gdb.base/shreloc2.c (fn_2): Reference variable static_var_2.

Cheers
- Wu Zhou


             reply	other threads:[~2005-05-17 14:39 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-17 15:15 Wu Zhou [this message]
2005-05-18  1:50 ` Daniel Jacobowitz
  -- strict thread matches above, loose matches on Subject: below --
2005-05-18  3:20 Wu Zhou
2005-05-17 13:32 Wu Zhou
2005-05-17 14:11 ` Daniel Jacobowitz
2005-05-09  6:28 Wu Zhou
2005-05-01  4:45 Wu Zhou
2005-05-01  4:36 Wu Zhou
2005-05-15 19:44 ` Daniel Jacobowitz
2005-05-01  4:19 Wu Zhou
2005-05-01  4:28 ` Daniel Jacobowitz
2005-04-13 17:14 Paul Gilliam
2005-04-14 19:23 ` Daniel Jacobowitz
2005-04-15 19:41   ` Paul Gilliam
2005-04-20  0:31   ` Paul Gilliam
2005-04-27 15:58     ` Daniel Jacobowitz
2005-04-29 23:15       ` Paul Gilliam
2005-04-30  9:06         ` Wu Zhou
2005-04-30 18:33           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1116340726.428a01f64cf3b@imap.linux.ibm.com \
    --to=woodzltc@cn.ibm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=pgilliam@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox