From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10650 invoked by alias); 17 May 2005 14:39:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 10348 invoked from network); 17 May 2005 14:38:57 -0000 Received: from unknown (HELO e6.ny.us.ibm.com) (32.97.182.146) by sourceware.org with SMTP; 17 May 2005 14:38:57 -0000 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e6.ny.us.ibm.com (8.12.11/8.12.11) with ESMTP id j4HEcvaC025631 for ; Tue, 17 May 2005 10:38:57 -0400 Received: from d01av03.pok.ibm.com (d01av03.pok.ibm.com [9.56.224.217]) by d01relay02.pok.ibm.com (8.12.10/NCO/VER6.6) with ESMTP id j4HEcvOt147832 for ; Tue, 17 May 2005 10:38:57 -0400 Received: from d01av03.pok.ibm.com (loopback [127.0.0.1]) by d01av03.pok.ibm.com (8.12.11/8.13.3) with ESMTP id j4HEcvX8007389 for ; Tue, 17 May 2005 10:38:57 -0400 Received: from imap.linux.ibm.com (imap.rtp.raleigh.ibm.com [9.42.107.100]) by d01av03.pok.ibm.com (8.12.11/8.12.11) with ESMTP id j4HEcvMl007367; Tue, 17 May 2005 10:38:57 -0400 Received: by imap.linux.ibm.com (Postfix, from userid 48) id AC1C77C009; Tue, 17 May 2005 10:38:46 -0400 (EDT) Received: from sig-9-65-75-76.mts.ibm.com (sig-9-65-75-76.mts.ibm.com [9.65.75.76]) by imap.rtp.raleigh.ibm.com (IMP) with HTTP for ; Tue, 17 May 2005 10:38:46 -0400 Message-ID: <1116340726.428a01f64cf3b@imap.linux.ibm.com> Date: Tue, 17 May 2005 15:15:00 -0000 From: Wu Zhou To: Daniel Jacobowitz Cc: pgilliam@us.ibm.com, gdb-patches@sources.redhat.com Subject: Re: [patch] update gdb.base/shreloc.exp to use new shared library infrastructure MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit User-Agent: Internet Messaging Program (IMP) 3.2.7 X-SW-Source: 2005-05/txt/msg00424.txt.bz2 Quoting Daniel Jacobowitz : > On Tue, May 17, 2005 at 06:20:02AM -0400, Wu Zhou wrote: > > Hi Daniel, > > > > Thanks for pointing out these errors for me. Followed is the re-worked > > patch. > > > > 2005-05-17 Paul Gilliam > > Wu Zhou > > > > * gdb.base/shreloc.exp: Use gdb_compile_shlib. Add support for > > IBM's xlc compiler. > > * gdb.base/shreloc1.c (fn_1): Reference variable static_var_1. > > * gdb.base/shreloc2.c (fn_2): Reference variable static_var_2. > > This is fine to commit; do you have write access? > > Make sure to use tabs at the beginning of lines in the ChangeLog, and > to put two spaces between your name and email address. No. I don't have write access yet. As you might know, I am very new to GDB development. Maybe I need some good patches to get the write access. So maybe someone else need to commit this(I can rewrite the changelog). I could ask Paul to do this. But if you are willing to do it, that will be highly appreciated. BTW. thanks for reminding me of the wording rules. And also for your kind helps all the way. I learned a lot from working with you on this first patch, which is also my first experience for contributing code to GNU projects. With your and others' kind help, I believe I can do much better next time. Thanks once again. ===============The re-worked changelog================================= 2005-05-17 Paul Gilliam Wu Zhou * gdb.base/shreloc.exp: Use gdb_compile_shlib. Add support for IBM's xlc compiler. * gdb.base/shreloc1.c (fn_1): Reference variable static_var_1. * gdb.base/shreloc2.c (fn_2): Reference variable static_var_2. Cheers - Wu Zhou