Re: RFA: Update ARM architecture selection, add set arm abi

[Richard Earnshaw <rearnsha@gcc.gnu.org>]

On Wed, 2005-03-30 at 21:31, Daniel Jacobowitz wrote:
> This patch redoes the way the ARM target handles the architecture's ABI and
> floating point model.  Right now we adjust the gdbarch in place when the FP
> model changes; but gdbarches are supposed to be read-only after their
> creation.  What we should do instead is use gdbarch_update_p for this
> purpose.  This also separates the ABI from the OSABI, for consistency with
> other architectures; this fixes assorted problems, including the core dump
> consistency discussed on gdb@ this week, and the use of the default OSABI
> for untagged binaries.  If you've ever had GDB set the wrong breakpoint
> instruction when debugging a GNU/Linux ld.so, this is why; the patch should
> fix it.
> 
> When creating an architecture we need to honor settings in this order:
>   - Global settings set by the user.
>   - Settings inferred from the current binary.
>   - Settings inherited from the last ARM architecture created.  This
>     is usually equivalent to the settings it inferred from the binary;
>     when gdbarch_update_p is used the new architecture is created without
>     a BFD.
>   - Defaults chosen by the architecture, in absence of anything else.
> 
> OK?  I've tested this as much as I can by inspection, on both APCS and AAPCS
> binaries, but another pair of eyes would be appreciated.  Revised versions
> of two of the csl-arm-branch patches will use this machinery.

Sorry for the delay getting around to reviewing this patch.

Yes, this is fine, thanks.

R.