Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com,
	Richard Earnshaw <Richard.Earnshaw@arm.com>
Subject: Re: RFA: Update ARM architecture selection, add set arm abi
Date: Wed, 06 Apr 2005 22:27:00 -0000	[thread overview]
Message-ID: <20050406222747.GA25866@nevyn.them.org> (raw)
In-Reply-To: <20050330203140.GA10953@nevyn.them.org>

On Wed, Mar 30, 2005 at 03:31:41PM -0500, Daniel Jacobowitz wrote:
> This patch redoes the way the ARM target handles the architecture's ABI and
> floating point model.  Right now we adjust the gdbarch in place when the FP
> model changes; but gdbarches are supposed to be read-only after their
> creation.  What we should do instead is use gdbarch_update_p for this
> purpose.  This also separates the ABI from the OSABI, for consistency with
> other architectures; this fixes assorted problems, including the core dump
> consistency discussed on gdb@ this week, and the use of the default OSABI
> for untagged binaries.  If you've ever had GDB set the wrong breakpoint
> instruction when debugging a GNU/Linux ld.so, this is why; the patch should
> fix it.
> 
> When creating an architecture we need to honor settings in this order:
>   - Global settings set by the user.
>   - Settings inferred from the current binary.
>   - Settings inherited from the last ARM architecture created.  This
>     is usually equivalent to the settings it inferred from the binary;
>     when gdbarch_update_p is used the new architecture is created without
>     a BFD.
>   - Defaults chosen by the architecture, in absence of anything else.
> 
> OK?  I've tested this as much as I can by inspection, on both APCS and AAPCS
> binaries, but another pair of eyes would be appreciated.  Revised versions
> of two of the csl-arm-branch patches will use this machinery.

Hi Richard,

Have you had a chance to look at this?


-- 
Daniel Jacobowitz
CodeSourcery, LLC


  reply	other threads:[~2005-04-06 22:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-03-30 20:30 Daniel Jacobowitz
2005-04-06 22:27 ` Daniel Jacobowitz [this message]
2005-04-09 13:04 ` Richard Earnshaw
2005-04-14 18:41   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050406222747.GA25866@nevyn.them.org \
    --to=drow@false.org \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox