From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31543 invoked by alias); 9 Apr 2005 13:04:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 31524 invoked from network); 9 Apr 2005 13:04:34 -0000 Received: from unknown (HELO cam-admin0.cambridge.arm.com) (193.131.176.58) by sourceware.org with SMTP; 9 Apr 2005 13:04:34 -0000 Received: from pc960.cambridge.arm.com (pc960.cambridge.arm.com [10.1.205.4]) by cam-admin0.cambridge.arm.com (8.12.10/8.12.10) with ESMTP id j39D3s4G014204; Sat, 9 Apr 2005 14:03:54 +0100 (BST) Received: from pc960.cambridge.arm.com (localhost.localdomain [127.0.0.1]) by pc960.cambridge.arm.com (8.12.8/8.12.8) with ESMTP id j39D4Dmf000836; Sat, 9 Apr 2005 14:04:13 +0100 Received: (from rearnsha@localhost) by pc960.cambridge.arm.com (8.12.8/8.12.8/Submit) id j39D4DT1000834; Sat, 9 Apr 2005 14:04:13 +0100 X-Authentication-Warning: pc960.cambridge.arm.com: rearnsha set sender to rearnsha@gcc.gnu.org using -f Subject: Re: RFA: Update ARM architecture selection, add set arm abi From: Richard Earnshaw To: Daniel Jacobowitz Cc: gdb-patches@sources.redhat.com In-Reply-To: <20050330203140.GA10953@nevyn.them.org> References: <20050330203140.GA10953@nevyn.them.org> Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: GNU Message-Id: <1113051852.695.4.camel@pc960.cambridge.arm.com> Mime-Version: 1.0 Date: Sat, 09 Apr 2005 13:04:00 -0000 X-SW-Source: 2005-04/txt/msg00083.txt.bz2 On Wed, 2005-03-30 at 21:31, Daniel Jacobowitz wrote: > This patch redoes the way the ARM target handles the architecture's ABI and > floating point model. Right now we adjust the gdbarch in place when the FP > model changes; but gdbarches are supposed to be read-only after their > creation. What we should do instead is use gdbarch_update_p for this > purpose. This also separates the ABI from the OSABI, for consistency with > other architectures; this fixes assorted problems, including the core dump > consistency discussed on gdb@ this week, and the use of the default OSABI > for untagged binaries. If you've ever had GDB set the wrong breakpoint > instruction when debugging a GNU/Linux ld.so, this is why; the patch should > fix it. > > When creating an architecture we need to honor settings in this order: > - Global settings set by the user. > - Settings inferred from the current binary. > - Settings inherited from the last ARM architecture created. This > is usually equivalent to the settings it inferred from the binary; > when gdbarch_update_p is used the new architecture is created without > a BFD. > - Defaults chosen by the architecture, in absence of anything else. > > OK? I've tested this as much as I can by inspection, on both APCS and AAPCS > binaries, but another pair of eyes would be appreciated. Revised versions > of two of the csl-arm-branch patches will use this machinery. Sorry for the delay getting around to reviewing this patch. Yes, this is fine, thanks. R.