* [trivial] remove references to add_setshow_cmd_full from arm-tdep.c
@ 2004-07-30 15:27 Ramana Radhakrishnan
2004-07-30 15:58 ` Richard Earnshaw
0 siblings, 1 reply; 6+ messages in thread
From: Ramana Radhakrishnan @ 2004-07-30 15:27 UTC (permalink / raw)
To: gdb-patches
Hi ,
While attempting to build cvs head now for arm-elf I ran into a problem
with add_setshow_cmd_full for apcs32. It has been made
static in cli-decode.c . Someone has corrected the call but not removed
the reference . So here goes.
This patch removes the reference. Below the call to add_setshow_cmd_full
and a call to add_setshow_cmd_boolean is present below. Ok to apply ?
cheers
Ramana
--- src/gdb/arm-tdep.c 2004-07-30 20:44:58.000000000 +0530
+++ src-working/gdb/arm-tdep.c 2004-07-30 20:54:09.000000000 +0530
@@ -2940,7 +2940,15 @@
set_cmd_sfunc (new_set, set_disassembly_style_sfunc);
deprecated_add_show_from_set (new_set, &showarmcmdlist);
-
+
+ add_setshow_cmd_full ("apcs32", no_class,
+ var_boolean, (char *) &arm_apcs_32, "\
+Set usage of ARM 32-bit mode.", "\
+Show usage of ARM 32-bit mode.", "\
+Determine the usage of ARM 32-bit mode.", "\
+Usage of ARM 32-bit mode is %s.",
+ NULL, NULL,
+ &setlist, &showlist, &new_set, &new_show);
deprecate_cmd (new_set, "set arm apcs32");
deprecate_cmd (new_show, "show arm apcs32");
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [trivial] remove references to add_setshow_cmd_full from arm-tdep.c
2004-07-30 15:27 [trivial] remove references to add_setshow_cmd_full from arm-tdep.c Ramana Radhakrishnan
@ 2004-07-30 15:58 ` Richard Earnshaw
2004-07-30 16:37 ` Ramana Radhakrishnan
0 siblings, 1 reply; 6+ messages in thread
From: Richard Earnshaw @ 2004-07-30 15:58 UTC (permalink / raw)
To: Ramana Radhakrishnan; +Cc: gdb-patches
On Fri, 2004-07-30 at 16:26, Ramana Radhakrishnan wrote:
> Hi ,
> While attempting to build cvs head now for arm-elf I ran into a problem
> with add_setshow_cmd_full for apcs32. It has been made
> static in cli-decode.c . Someone has corrected the call but not removed
> the reference . So here goes.
>
> This patch removes the reference. Below the call to add_setshow_cmd_full
> and a call to add_setshow_cmd_boolean is present below. Ok to apply ?
>
> cheers
> Ramana
>
This isn't correct.
1) No ChangeLog entry
2) It's adding code, yet you claim you're removing code.
3) (assuming the patch is inverted somehow) It removes the
initialization of new_set and new_show, but you've left the subsequent
deprecate_cmd calls.
R.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [trivial] remove references to add_setshow_cmd_full from arm-tdep.c
2004-07-30 15:58 ` Richard Earnshaw
@ 2004-07-30 16:37 ` Ramana Radhakrishnan
2004-07-30 16:56 ` Richard Earnshaw
0 siblings, 1 reply; 6+ messages in thread
From: Ramana Radhakrishnan @ 2004-07-30 16:37 UTC (permalink / raw)
To: Richard Earnshaw; +Cc: gdb-patches
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
Hi Richard,
Oops.I am sorry about making that patch in a hurry. That should teach
me .I hope its ok this time round. Here we go again .
cheers
Ramana
---
2004-07-30 Ramana Radhakrishnan <ramana.radhakrishnan@codito.com>
* arm-tdep.c: Remove references to add_setshow_cmd_full for apcs32 .
Is this ok ?
regards
Ramana
[-- Attachment #2: diffs --]
[-- Type: text/x-patch, Size: 950 bytes --]
Index: arm-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/arm-tdep.c,v
retrieving revision 1.179
diff -u -r1.179 arm-tdep.c
--- arm-tdep.c 28 Jul 2004 17:26:26 -0000 1.179
+++ arm-tdep.c 30 Jul 2004 16:35:53 -0000
@@ -2941,17 +2941,6 @@
set_cmd_sfunc (new_set, set_disassembly_style_sfunc);
deprecated_add_show_from_set (new_set, &showarmcmdlist);
- add_setshow_cmd_full ("apcs32", no_class,
- var_boolean, (char *) &arm_apcs_32, "\
-Set usage of ARM 32-bit mode.", "\
-Show usage of ARM 32-bit mode.", "\
-Determine the usage of ARM 32-bit mode.", "\
-Usage of ARM 32-bit mode is %s.",
- NULL, NULL,
- &setlist, &showlist, &new_set, &new_show);
- deprecate_cmd (new_set, "set arm apcs32");
- deprecate_cmd (new_show, "show arm apcs32");
-
add_setshow_boolean_cmd ("apcs32", no_class, &arm_apcs_32, "\
Set usage of ARM 32-bit mode.", "\
Show usage of ARM 32-bit mode.", "\
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [trivial] remove references to add_setshow_cmd_full from arm-tdep.c
2004-07-30 16:37 ` Ramana Radhakrishnan
@ 2004-07-30 16:56 ` Richard Earnshaw
2004-07-31 5:52 ` Ramana Radhakrishnan
2004-08-01 19:29 ` Andrew Cagney
0 siblings, 2 replies; 6+ messages in thread
From: Richard Earnshaw @ 2004-07-30 16:56 UTC (permalink / raw)
To: ramana.radhakrishnan; +Cc: gdb-patches
On Fri, 2004-07-30 at 17:36, Ramana Radhakrishnan wrote:
> Hi Richard,
>
> Oops.I am sorry about making that patch in a hurry. That should teach
> me .I hope its ok this time round. Here we go again .
>
> cheers
> Ramana
>
> ---
>
>
> 2004-07-30 Ramana Radhakrishnan <ramana.radhakrishnan@codito.com>
>
> * arm-tdep.c: Remove references to add_setshow_cmd_full for apcs32 .
>
>
>
> Is this ok ?
Yes.
Note that your initial analysis (about the command below the one you are
removing) was slightly off base, but in this case it doesn't matter.
The command you are removing was 'set apcs32' which was deprecated by
'set arm apcs32'. However, since that command was deprecated gdb 6.0,
6.1 and (AIUI) 6.2 have all been made, so I think it's now safe to
remove the old variant.
R.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-08-01 19:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-07-30 15:27 [trivial] remove references to add_setshow_cmd_full from arm-tdep.c Ramana Radhakrishnan
2004-07-30 15:58 ` Richard Earnshaw
2004-07-30 16:37 ` Ramana Radhakrishnan
2004-07-30 16:56 ` Richard Earnshaw
2004-07-31 5:52 ` Ramana Radhakrishnan
2004-08-01 19:29 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox