From: Richard Earnshaw <rearnsha@gcc.gnu.org>
To: Ramana Radhakrishnan <ramana.radhakrishnan@codito.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [trivial] remove references to add_setshow_cmd_full from arm-tdep.c
Date: Fri, 30 Jul 2004 15:58:00 -0000 [thread overview]
Message-ID: <1091203105.31643.103.camel@pc960.cambridge.arm.com> (raw)
In-Reply-To: <410A68AE.2090004@codito.com>
On Fri, 2004-07-30 at 16:26, Ramana Radhakrishnan wrote:
> Hi ,
> While attempting to build cvs head now for arm-elf I ran into a problem
> with add_setshow_cmd_full for apcs32. It has been made
> static in cli-decode.c . Someone has corrected the call but not removed
> the reference . So here goes.
>
> This patch removes the reference. Below the call to add_setshow_cmd_full
> and a call to add_setshow_cmd_boolean is present below. Ok to apply ?
>
> cheers
> Ramana
>
This isn't correct.
1) No ChangeLog entry
2) It's adding code, yet you claim you're removing code.
3) (assuming the patch is inverted somehow) It removes the
initialization of new_set and new_show, but you've left the subsequent
deprecate_cmd calls.
R.
next prev parent reply other threads:[~2004-07-30 15:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-30 15:27 Ramana Radhakrishnan
2004-07-30 15:58 ` Richard Earnshaw [this message]
2004-07-30 16:37 ` Ramana Radhakrishnan
2004-07-30 16:56 ` Richard Earnshaw
2004-07-31 5:52 ` Ramana Radhakrishnan
2004-08-01 19:29 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1091203105.31643.103.camel@pc960.cambridge.arm.com \
--to=rearnsha@gcc.gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=ramana.radhakrishnan@codito.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox