From: Kevin Buettner <kevinb@redhat.com>
To: tromey@redhat.com, Jim Blandy <jimb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH RFC] Character set support
Date: Thu, 19 Sep 2002 17:46:00 -0000 [thread overview]
Message-ID: <1020920004553.ZM23176@localhost.localdomain> (raw)
In-Reply-To: Kevin Buettner <kevinb@redhat.com> "Re: [PATCH RFC] Character set support" (Sep 19, 5:36pm)
On Sep 19, 5:36pm, Kevin Buettner wrote:
> I ended up with a conflict when I updated c-lang.c. I'm reposting
> that portion of the patch since it is somewhat different than what I
> originally posted. The conflict was due to Tom Tromey's additon of
> the embedded \0 disambiguation code in c_emit_char(). I'd appreciate
> it if both Tom and Jim would look over this patch to see if it looks
> sensible. I've run the testsuite and have done some testing by hand and
> the results look good to me...
BTW, the portion to look at is:
> + if (quoter == '"' && strcmp (escape, "0") == 0)
> + /* Print nulls embedded in double quoted strings as \000 to
> + prevent ambiguity. */
> + fprintf_filtered (stream, "\\000");
> + else
> + fprintf_filtered (stream, "\\%s", escape);
vs.
> - case '\0':
> - if (quoter == '\'')
> - fputs_filtered ("\\0", stream);
> - else
> - fprintf_filtered (stream, "\\%.3o", (unsigned int) c);
> - break;
Kevin
next prev parent reply other threads:[~2002-09-20 0:46 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-09-12 17:31 Kevin Buettner
2002-09-12 17:41 ` Daniel Jacobowitz
2002-09-12 20:24 ` Jim Blandy
2002-09-12 20:45 ` Andrew Cagney
2002-09-13 10:05 ` Jim Blandy
2002-09-13 11:39 ` Andrew Cagney
2002-09-13 19:06 ` Jim Blandy
2002-09-16 22:25 ` Andrew Cagney
2002-09-19 12:52 ` Jim Blandy
2002-09-19 13:27 ` Kevin Buettner
2002-09-20 13:49 ` Eli Zaretskii
2002-09-13 7:02 ` Daniel Jacobowitz
2002-09-13 10:16 ` Jim Blandy
2002-09-13 10:33 ` Daniel Jacobowitz
2002-09-13 11:42 ` Andrew Cagney
2002-09-13 12:11 ` Kevin Buettner
2002-09-13 12:15 ` Daniel Jacobowitz
2002-09-12 17:53 ` Andrew Cagney
2002-09-12 18:08 ` Kevin Buettner
2002-09-19 17:36 ` Kevin Buettner
2002-09-19 17:46 ` Kevin Buettner [this message]
2002-09-19 18:12 ` Andrew Cagney
2002-09-20 0:12 ` Kevin Buettner
2002-09-20 9:08 ` Andrew Cagney
2002-09-20 14:58 ` Kevin Buettner
2002-09-20 16:33 ` Andrew Cagney
2002-09-21 1:26 ` Eli Zaretskii
2002-09-20 16:55 ` Kevin Buettner
2002-09-20 8:59 ` Eli Zaretskii
2002-09-20 17:34 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1020920004553.ZM23176@localhost.localdomain \
--to=kevinb@redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=jimb@redhat.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox