From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30965 invoked by alias); 20 Sep 2002 00:46:04 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30931 invoked from network); 20 Sep 2002 00:46:00 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 20 Sep 2002 00:46:00 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200]) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id g8K0Sei24718 for ; Thu, 19 Sep 2002 20:28:40 -0400 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id g8K0jvx24565; Thu, 19 Sep 2002 20:45:57 -0400 Received: from romulus.sfbay.redhat.com (IDENT:biKPEASjpBixwdk3h+8ZRJr4JMjJ3+e9@romulus.sfbay.redhat.com [172.16.27.251]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id g8K0jtC28717; Thu, 19 Sep 2002 17:45:56 -0700 Received: (from kev@localhost) by romulus.sfbay.redhat.com (8.11.6/8.11.6) id g8K0jrv23177; Thu, 19 Sep 2002 17:45:53 -0700 Date: Thu, 19 Sep 2002 17:46:00 -0000 From: Kevin Buettner Message-Id: <1020920004553.ZM23176@localhost.localdomain> In-Reply-To: Kevin Buettner "Re: [PATCH RFC] Character set support" (Sep 19, 5:36pm) References: <1020913003056.ZM15701@localhost.localdomain> <1020920003625.ZM23109@localhost.localdomain> To: tromey@redhat.com, Jim Blandy Subject: Re: [PATCH RFC] Character set support Cc: gdb-patches@sources.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-09/txt/msg00508.txt.bz2 On Sep 19, 5:36pm, Kevin Buettner wrote: > I ended up with a conflict when I updated c-lang.c. I'm reposting > that portion of the patch since it is somewhat different than what I > originally posted. The conflict was due to Tom Tromey's additon of > the embedded \0 disambiguation code in c_emit_char(). I'd appreciate > it if both Tom and Jim would look over this patch to see if it looks > sensible. I've run the testsuite and have done some testing by hand and > the results look good to me... BTW, the portion to look at is: > + if (quoter == '"' && strcmp (escape, "0") == 0) > + /* Print nulls embedded in double quoted strings as \000 to > + prevent ambiguity. */ > + fprintf_filtered (stream, "\\000"); > + else > + fprintf_filtered (stream, "\\%s", escape); vs. > - case '\0': > - if (quoter == '\'') > - fputs_filtered ("\\0", stream); > - else > - fprintf_filtered (stream, "\\%.3o", (unsigned int) c); > - break; Kevin