Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: "David S. Miller" <davem@redhat.com>, ac131313@cygnus.com
Cc: shebs@apple.com, drow@mvista.com, gdb-patches@sources.redhat.com
Subject: Re: which patches to review
Date: Wed, 24 Apr 2002 12:16:00 -0000	[thread overview]
Message-ID: <1020424191644.ZM15056@localhost.localdomain> (raw)
In-Reply-To: "David S. Miller" <davem@redhat.com> "Re: which patches to review" (Apr 24, 10:38am)

On Apr 24, 10:38am, David S. Miller wrote:

> Right now all of the Sparc Linux bits are in a pending state because
> they need to be sequenced after the multi-arch bits.  Currently, this
> one is holding up sparc-linux-tdep from being added:
> 
> 	http://sources.redhat.com/ml/gdb-patches/2002-04/msg00710.html

I just took a quick look at this one and I think it's okay.  I was
going to complain about the fact this...

+#if (GDB_TARGET_IS_SPARC64)
+#define FP_MAX_REGNUM (FP0_REGNUM + 48)
+#else
+#define FP_MAX_REGNUM (FP0_REGNUM + 32)
+#endif

...appears in the new sparc-tdep.h, but then I realized that this was
simply moved over verbatim from sparc-tdep.c.  It seems reasonable to
me that this could/should be cleaned up in a later patch.

Anyway, I recommend that David's lynch-pin patch be approved.

Kevin


  reply	other threads:[~2002-04-24 19:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-22 22:49 David S. Miller
2002-04-23  7:47 ` Elena Zannoni
2002-04-23  7:54   ` Daniel Jacobowitz
2002-04-23 22:19     ` David S. Miller
2002-04-24  8:53       ` Stan Shebs
2002-04-24 10:16         ` Andrew Cagney
2002-04-24 10:48           ` David S. Miller
2002-04-24 12:16             ` Kevin Buettner [this message]
2002-04-24 12:25               ` David S. Miller
2002-04-25  7:04                 ` Andrew Cagney
     [not found]                   ` <mailpost.1019743470.13502@news-sj1-1>
2002-04-25  9:19                     ` cgd
2002-04-25  7:32             ` Andrew Cagney
2002-04-25 18:04               ` David S. Miller
2002-04-25 20:27                 ` Andrew Cagney
2002-04-25 18:14               ` Daniel Jacobowitz
2002-04-25 18:36                 ` Christopher Faylor
2002-04-25 18:45                   ` Daniel Jacobowitz
2002-04-25 19:17                     ` Christopher Faylor
2002-04-25 20:33                       ` Andrew Cagney
2002-04-26  9:26                     ` Stan Shebs
2002-04-25 20:17                 ` Andrew Cagney
2002-04-25 22:00                   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1020424191644.ZM15056@localhost.localdomain \
    --to=kevinb@redhat.com \
    --cc=ac131313@cygnus.com \
    --cc=davem@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=shebs@apple.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox