* [PATCH] Update comment in remote_can_async_p
@ 2017-01-11 15:36 Simon Marchi
2017-01-12 16:12 ` Pedro Alves
0 siblings, 1 reply; 3+ messages in thread
From: Simon Marchi @ 2017-01-11 15:36 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
I find this comment counter intuitive, and it probably predates the
always-target-async change. AFAIK, remote will always be async, unless
the user explicitly prevents it with "maint set target-async off".
gdb/ChangeLog:
* remote.c (remote_can_async_p): Update comment.
---
gdb/remote.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gdb/remote.c b/gdb/remote.c
index 837b9ee512..c73c30aacd 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -13653,8 +13653,9 @@ remote_can_async_p (struct target_ops *ops)
{
struct remote_state *rs = get_remote_state ();
+ /* We don't go async if the user has explicitly prevented it with the
+ "maint set target-async" command. */
if (!target_async_permitted)
- /* We only enable async when the user specifically asks for it. */
return 0;
/* We're async whenever the serial device is. */
--
2.11.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Update comment in remote_can_async_p
2017-01-11 15:36 [PATCH] Update comment in remote_can_async_p Simon Marchi
@ 2017-01-12 16:12 ` Pedro Alves
2017-01-12 16:15 ` Simon Marchi
0 siblings, 1 reply; 3+ messages in thread
From: Pedro Alves @ 2017-01-12 16:12 UTC (permalink / raw)
To: Simon Marchi, gdb-patches
On 01/11/2017 03:35 PM, Simon Marchi wrote:
> gdb/ChangeLog:
>
> * remote.c (remote_can_async_p): Update comment.
OK.
/me clears old entry from his TODO.
Thanks!
--
Pedro Alves
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Update comment in remote_can_async_p
2017-01-12 16:12 ` Pedro Alves
@ 2017-01-12 16:15 ` Simon Marchi
0 siblings, 0 replies; 3+ messages in thread
From: Simon Marchi @ 2017-01-12 16:15 UTC (permalink / raw)
To: Pedro Alves; +Cc: Simon Marchi, gdb-patches
On 2017-01-12 11:12, Pedro Alves wrote:
> On 01/11/2017 03:35 PM, Simon Marchi wrote:
>
>> gdb/ChangeLog:
>>
>> * remote.c (remote_can_async_p): Update comment.
>
> OK.
>
> /me clears old entry from his TODO.
>
> Thanks!
Thanks, pushed!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-12 16:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-11 15:36 [PATCH] Update comment in remote_can_async_p Simon Marchi
2017-01-12 16:12 ` Pedro Alves
2017-01-12 16:15 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox