From: Simon Marchi <simon.marchi@ericsson.com>
To: <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: [PATCH] Update comment in remote_can_async_p
Date: Wed, 11 Jan 2017 15:36:00 -0000 [thread overview]
Message-ID: <20170111153559.8336-1-simon.marchi@ericsson.com> (raw)
I find this comment counter intuitive, and it probably predates the
always-target-async change. AFAIK, remote will always be async, unless
the user explicitly prevents it with "maint set target-async off".
gdb/ChangeLog:
* remote.c (remote_can_async_p): Update comment.
---
gdb/remote.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/gdb/remote.c b/gdb/remote.c
index 837b9ee512..c73c30aacd 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -13653,8 +13653,9 @@ remote_can_async_p (struct target_ops *ops)
{
struct remote_state *rs = get_remote_state ();
+ /* We don't go async if the user has explicitly prevented it with the
+ "maint set target-async" command. */
if (!target_async_permitted)
- /* We only enable async when the user specifically asks for it. */
return 0;
/* We're async whenever the serial device is. */
--
2.11.0
next reply other threads:[~2017-01-11 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 15:36 Simon Marchi [this message]
2017-01-12 16:12 ` Pedro Alves
2017-01-12 16:15 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111153559.8336-1-simon.marchi@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox