From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't include gdbarch.h from defs.h
Date: Wed, 10 Jul 2019 19:12:00 -0000 [thread overview]
Message-ID: <0c11d48f648433f9afb55c48798da3ae@polymtl.ca> (raw)
In-Reply-To: <20190614211035.398-1-tom@tromey.com>
On 2019-06-14 17:10, Tom Tromey wrote:
> I touched symtab.h and was surprised to see how many files were
> rebuilt. I looked into it a bit, and found that defs.h includes
> gdbarch.h, which in turn includes many things.
>
> gdbarch.h is only needed by a minority ofthe files in gdb, so this
> patch removes the include from defs.h and updates the fallout.
>
> I did "wc -l" on the files in build/gdb/.deps; this patch reduces the
> line count from 139935 to 137030; so there are definitely future
> build-time savings here.
>
> Note that while I configured with --enable-targets=all, it's possible
> that some *-nat.c file needs an update. I could not test all of
> these. The buildbot caught a few problems along these lines.
Thanks, I think this makes sense.
Simon
next prev parent reply other threads:[~2019-07-10 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 21:10 Tom Tromey
2019-07-10 18:40 ` Tom Tromey
2019-07-10 19:12 ` Simon Marchi [this message]
2019-07-10 20:57 ` Tom Tromey
[not found] ` <mvmy30e71pj.fsf@suse.de>
2019-07-31 17:48 ` Tom Tromey
2019-08-01 12:21 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c11d48f648433f9afb55c48798da3ae@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox