Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andreas Schwab <schwab@suse.de>
Cc: Tom Tromey <tom@tromey.com>,  gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't include gdbarch.h from defs.h
Date: Wed, 31 Jul 2019 17:48:00 -0000	[thread overview]
Message-ID: <87ftmmhz7m.fsf@tromey.com> (raw)
In-Reply-To: <mvmy30e71pj.fsf@suse.de> (Andreas Schwab's message of "Wed, 31	Jul 2019 15:50:16 +0200")

>>>>> "Andreas" == Andreas Schwab <schwab@suse.de> writes:

Andreas> In file included from ../../gdb/ia64-tdep.h:25:0,
Andreas>                  from ../../gdb/ia64-linux-tdep.c:21:
Andreas> ../../gdb/ia64-libunwind-tdep.h:74:11: error: ‘readable_regcache’ has not been declared
Andreas>            readable_regcache *regcache,

I don't have libunwind-ia64.h, so I couldn't reproduce this locally.

Anyway, please try the appended.  Maybe it will work.

thanks,
Tom

diff --git a/gdb/ia64-libunwind-tdep.h b/gdb/ia64-libunwind-tdep.h
index 3ad3d44f367..06a8d5463d7 100644
--- a/gdb/ia64-libunwind-tdep.h
+++ b/gdb/ia64-libunwind-tdep.h
@@ -36,6 +36,8 @@ struct frame_unwind;
    running on.  */
 #include "libunwind-ia64.h"
 
+#include "gdbarch.h"
+
 struct libunwind_descr
 {
   int (*gdb2uw) (int);


  parent reply	other threads:[~2019-07-31 17:48 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 21:10 Tom Tromey
2019-07-10 18:40 ` Tom Tromey
2019-07-10 19:12 ` Simon Marchi
2019-07-10 20:57   ` Tom Tromey
     [not found] ` <mvmy30e71pj.fsf@suse.de>
2019-07-31 17:48   ` Tom Tromey [this message]
2019-08-01 12:21     ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ftmmhz7m.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox