From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90222 invoked by alias); 10 Jul 2019 19:12:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 89995 invoked by uid 89); 10 Jul 2019 19:12:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=savings X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 10 Jul 2019 19:12:18 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x6AJCAvv026955 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 10 Jul 2019 15:12:16 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x6AJCAvv026955 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1562785937; bh=eLA177ED14tie/iWZDT02WfO3DeOgPatEPNwh+twPsM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=a6wD+i+qXlOcV1YxxPLo7W0n9bIzp597NktMlOPrU55jRn8smmajPjT7fyxvkGown ww2qX7+hiVmgby93eb0+PXc1RiIA4huP042MmlDFITrDHAehD7KXzQAPzEbtc1dU2p 5uYnDMXw43QP8Kdl/OGDm9M2VdA8gFBP7eXTLdxY= Received: by simark.ca (Postfix, from userid 112) id 047071EC9B; Wed, 10 Jul 2019 15:12:10 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 4FD741E472; Wed, 10 Jul 2019 15:12:09 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 10 Jul 2019 19:12:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Don't include gdbarch.h from defs.h In-Reply-To: <20190614211035.398-1-tom@tromey.com> References: <20190614211035.398-1-tom@tromey.com> Message-ID: <0c11d48f648433f9afb55c48798da3ae@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2019-07/txt/msg00280.txt.bz2 On 2019-06-14 17:10, Tom Tromey wrote: > I touched symtab.h and was surprised to see how many files were > rebuilt. I looked into it a bit, and found that defs.h includes > gdbarch.h, which in turn includes many things. > > gdbarch.h is only needed by a minority ofthe files in gdb, so this > patch removes the include from defs.h and updates the fallout. > > I did "wc -l" on the files in build/gdb/.deps; this patch reduces the > line count from 139935 to 137030; so there are definitely future > build-time savings here. > > Note that while I configured with --enable-targets=all, it's possible > that some *-nat.c file needs an update. I could not test all of > these. The buildbot caught a few problems along these lines. Thanks, I think this makes sense. Simon