From: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] [gdb/symtab] Fix assert in read_addrmap_from_aranges
Date: Fri, 5 Aug 2022 16:03:04 -0400 [thread overview]
Message-ID: <0aff8f76-bfe0-a62e-421b-921aa6d7946e@simark.ca> (raw)
In-Reply-To: <20220805114116.8338-2-tdevries@suse.de>
> +save_vars { Dwarf::_add_dummy_cus } {
> +
> + set Dwarf::_add_dummy_cus 0
Could we make that an option to Dwarf::assemble? Just an idea, turn:
proc assemble {filename body}
into
proc assemble {options body}
... where options could be:
Dwarf::assemble {
filename $asm_file
add_dummy_cus 0
} {
... body ...
}
And if $options is of length one, you transform it into
{filename $options}
such that existing test cases don't have to be changed.
Simon
next prev parent reply other threads:[~2022-08-05 20:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-05 11:41 [PATCH 1/2] [gdb/testsuite] Add support for .debug_names in dwarf assembler Tom de Vries via Gdb-patches
2022-08-05 11:41 ` [PATCH 2/2] [gdb/symtab] Fix assert in read_addrmap_from_aranges Tom de Vries via Gdb-patches
2022-08-05 20:03 ` Simon Marchi via Gdb-patches [this message]
2022-08-07 6:35 ` Tom de Vries via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aff8f76-bfe0-a62e-421b-921aa6d7946e@simark.ca \
--to=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox