From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id qrZxFI937WLLcCEAWB0awg (envelope-from ) for ; Fri, 05 Aug 2022 16:03:27 -0400 Received: by simark.ca (Postfix, from userid 112) id 489D41EA05; Fri, 5 Aug 2022 16:03:27 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=G+bckZ46; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A99F71E745 for ; Fri, 5 Aug 2022 16:03:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1FD093857361 for ; Fri, 5 Aug 2022 20:03:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1FD093857361 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1659729806; bh=aRGyVAmkqI+ixNeukutzM2Z9AXj8o2tYBjzLpROaaYY=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=G+bckZ46/z0gxqoTes1kgrgloNN+iwBy9dFhm/fikEcW3V6G9AT/2IukyckEoNMhD he3RprhssQVrWhXgzFFxrRmDlKy1m99lw9tOOHLobgT+y9FTjW+gJUjxWg+7fcwpSv 666IP8CdRD5Rtg6qq7bOpiRAm7vk8lnu1SD9GaDM= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 0A03F3858C2D for ; Fri, 5 Aug 2022 20:03:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0A03F3858C2D Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CA1D91E745; Fri, 5 Aug 2022 16:03:04 -0400 (EDT) Message-ID: <0aff8f76-bfe0-a62e-421b-921aa6d7946e@simark.ca> Date: Fri, 5 Aug 2022 16:03:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 2/2] [gdb/symtab] Fix assert in read_addrmap_from_aranges Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20220805114116.8338-1-tdevries@suse.de> <20220805114116.8338-2-tdevries@suse.de> In-Reply-To: <20220805114116.8338-2-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > +save_vars { Dwarf::_add_dummy_cus } { > + > + set Dwarf::_add_dummy_cus 0 Could we make that an option to Dwarf::assemble? Just an idea, turn: proc assemble {filename body} into proc assemble {options body} ... where options could be: Dwarf::assemble { filename $asm_file add_dummy_cus 0 } { ... body ... } And if $options is of length one, you transform it into {filename $options} such that existing test cases don't have to be changed. Simon