Re: [PATCH 2/2] [gdb/symtab] Fix assert in read_addrmap_from_aranges

[Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>]

On 8/5/22 22:03, Simon Marchi wrote:
> 
> 
>> +save_vars { Dwarf::_add_dummy_cus } {
>> +
>> +    set Dwarf::_add_dummy_cus 0
> 
> Could we make that an option to Dwarf::assemble?  Just an idea, turn:
> 
>    proc assemble {filename body}
> 
> into
> 
>    proc assemble {options body}
> 
> ... where options could be:
> 
>    Dwarf::assemble {
>      filename $asm_file
>      add_dummy_cus 0
>    } {
>      ... body ...
>    }
> 
> And if $options is of length one, you transform it into
> 
>    {filename $options}
> 
> such that existing test cases don't have to be changed.
> 

Done, and committed.

[ FWIW, I noticed that this works when there are no spaces in filenames, 
otherwise llength > 1. ]

Also added an extra test-case for the non-ascending warning.  And I've 
added checking for the specific warning in the test-cases.

Thanks,
- Tom